You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/07/18 03:44:02 UTC

[GitHub] [skywalking-rocketbot-ui] alonelaval opened a new pull request #331: Add PyMsql icon

alonelaval opened a new pull request #331:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/331


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #331: Add PyMsql icon

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #331:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/331#issuecomment-660499271


   The submodule of the main repo is required to be updated


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #331: Add PyMsql icon

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #331:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/331#issuecomment-660499481


   @kezhenxu94 By looking at https://github.com/apache/skywalking/pull/5121, I feel this PR is not right. MySQL already has one icon, we don't need the PyMsql, anything I missed? If not, this PR should be reverted.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking-rocketbot-ui] wu-sheng merged pull request #331: Add PyMsql icon

Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #331:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/331


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org