[GitHub] jmeter pull request #341: Test isIgnore after post processor and assertions

[max3163 <gi...@git.apache.org>]

GitHub user max3163 opened a pull request:

    https://github.com/apache/jmeter/pull/341

    Test isIgnore after post processor and assertions

    Actually, the new setIgnore() method allow to not send the sampleResut to all listeners. 
    But you have to set the property in the sampler, you can't change it on a post-processor or in a assertion script.
    
    This PR allow it

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/max3163/jmeter BZ60829_SetIgnore

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/jmeter/pull/341.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #341
    
----
commit 1cbc3c10a957f378e41048c60e49620a312daba0
Author: Chassagneux Maxime <41...@airfrance.fr>
Date:   2017-11-24T10:58:31Z

    Test isIgnore after post processor and assertions

----


---

[GitHub] jmeter issue #341: Test isIgnore after post processor and assertions

[FSchumacher <gi...@git.apache.org>]

Github user FSchumacher commented on the issue:

    https://github.com/apache/jmeter/pull/341
  
    Yes, but also to enable us to filter in view results tree on those meta information. It could be something like a comment, a thread name or anything else.


---

[GitHub] jmeter issue #341: Test isIgnore after post processor and assertions

[pmouawad <gi...@git.apache.org>]

Github user pmouawad commented on the issue:

    https://github.com/apache/jmeter/pull/341
  
    Hi @FSchumacher ,
    Good idea.
    Is this in relation with https://github.com/apache/jmeter/pull/313 ?
    Thanks


---

[GitHub] jmeter pull request #341: Test isIgnore after post processor and assertions

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/jmeter/pull/341


---

[GitHub] jmeter issue #341: Test isIgnore after post processor and assertions

[pmouawad <gi...@git.apache.org>]

Github user pmouawad commented on the issue:

    https://github.com/apache/jmeter/pull/341
  
    Hi @max3163 ,
    0/ In order to justify the user case, can you illustrate your use case ?
    1/ I think we should add a log in debug level when we ignore a SampleResult
    2/ Could you also add either a JUnit or an integration test (jmx test) that tests different cases:
    - ignore only in JSR223Sampler
    - ignore only in Assertion
    - ignore only in PostProcessor
    3/ Can you add a comment on the reason for the multiple test ? when reading the code, I forgot for few minutes the initial intent ,and it was not clear for me. 
    Comment like:
    "setIgnore can be called in Assertion or PostProcessors so test again"
    
    
    Thanks


---

[GitHub] jmeter issue #341: Test isIgnore after post processor and assertions

[FSchumacher <gi...@git.apache.org>]

Github user FSchumacher commented on the issue:

    https://github.com/apache/jmeter/pull/341
  
    I wonder, whether instead of or additionally to the new `setIgnore` method, we should add and expose a `setMetadata(type, content)` method.
    I believe it would be useful for example to:
    * mark samples to be ignored by listeners and such
    * use the information later on to group by (a use case would be to group by some user given metadata in the view results tree)


---