[GitHub] [pulsar] massakam commented on a change in pull request #5246: [WIP][Issue #5234][pulsar-client-cpp] Fix memory leak caused by deadline_timer holding object reference

[GitBox <gi...@apache.org>]

massakam commented on a change in pull request #5246: [WIP][Issue #5234][pulsar-client-cpp] Fix memory leak caused by deadline_timer holding object reference
URL: https://github.com/apache/pulsar/pull/5246#discussion_r327601394
 
 

 ##########
 File path: pulsar-client-cpp/lib/ClientConnection.cc
 ##########
 @@ -1382,6 +1385,10 @@ void ClientConnection::close() {
     if (tlsSocket_) {
         tlsSocket_->lowest_layer().close();
     }
+
+    if (executor_) {
+        executor_.reset();
 
 Review comment:
   The program doesn't seem to stop unless `executor_` is reset here. However, the `ClientConnection` destructor is not executed, causing a memory leak.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services