You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Tzu-Li (Gordon) Tai (JIRA)" <ji...@apache.org> on 2019/04/10 08:00:10 UTC
[jira] [Closed] (FLINK-12121) Use composition instead of
inheritance for the InternalKeyContext logic in backend
[ https://issues.apache.org/jira/browse/FLINK-12121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tzu-Li (Gordon) Tai closed FLINK-12121.
---------------------------------------
Resolution: Fixed
Fix Version/s: 1.9.0
> Use composition instead of inheritance for the InternalKeyContext logic in backend
> ----------------------------------------------------------------------------------
>
> Key: FLINK-12121
> URL: https://issues.apache.org/jira/browse/FLINK-12121
> Project: Flink
> Issue Type: Improvement
> Components: Runtime / State Backends
> Reporter: Yu Li
> Assignee: Yu Li
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.9.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Commonly it's [recommended|https://stackoverflow.com/questions/2399544/difference-between-inheritance-and-composition] to favor composition over inheritance in java design, but currently in keyed backend we're using inheritance for the {{InternalKeyContext}} logic, and here we propose to change to the composition way.
> Another advantage of changing to the composition way is that we could remove the requirement of a heap backend instance when constructing {{HeapRestoreOperation}}, and further making sure all fields are final when constructing the {{HeapKeyedStateBackend}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)