You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/10/21 01:03:14 UTC

[GitHub] [calcite] julianhyde commented on issue #1523: [CALCITE-3432] RexBuilder construct method with the default of RelDataTypeFactory.

julianhyde commented on issue #1523: [CALCITE-3432] RexBuilder construct method with the default of RelDataTypeFactory.
URL: https://github.com/apache/calcite/pull/1523#issuecomment-544312710
 
 
   I don't think this is a useful change. People might accidentally create a RexBuilder with a different type factory than is used elsewhere in their code.
   
   There's probably some code in Planner or Frameworks that creates everything that people need.
   
   Or you can add it to your own utility class. I'd recommend that you add javadoc explaining what it is doing.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services