[jira] [Commented] (GEODE-8241) Locator does not observe locator-wait-time

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-8241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17132805#comment-17132805 ] 

ASF GitHub Bot commented on GEODE-8241:
---------------------------------------

aaronlindsey commented on pull request #5236:
URL: https://github.com/apache/geode/pull/5236#issuecomment-642338908


   @vfordpivotal please review


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Locator does not observe locator-wait-time
> ------------------------------------------
>
>                 Key: GEODE-8241
>                 URL: https://issues.apache.org/jira/browse/GEODE-8241
>             Project: Geode
>          Issue Type: Bug
>            Reporter: Aaron Lindsey
>            Assignee: Aaron Lindsey
>            Priority: Major
>
> In the case where a locator starts up and is unable to connect to any other locators, it may decide to become the membership coordinator even if locator-wait-time has not elapsed.
> The following conditional from GMSJoinLeave.java causes the issue. There should be an additional check for locator-wait-time before becoming coordinator.
> {code:java}
>             if (state.joinedMembersContacted <= 0 &&
>                 (tries >= minimumRetriesBeforeBecomingCoordinator ||
>                     state.locatorsContacted >= locators.size())) {
>               synchronized (viewInstallationLock) {
>                 becomeCoordinator();
>               }
>               return true;
>             }
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)