You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@plc4x.apache.org by GitBox <gi...@apache.org> on 2021/01/16 12:00:15 UTC

[GitHub] [plc4x] hutcheb opened a new pull request #223: Updated Notice and License files.

hutcheb opened a new pull request #223:
URL: https://github.com/apache/plc4x/pull/223


   To take into account for derivative works licenses under EPL 2.0


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [GitHub] [plc4x] chrisdutz merged pull request #223: Updated Notice and License files.

Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,

I’ve nt taken a deep look at this but EPL licensed code isn’t allowed in a source release. [1]

Thanks,
Justin

1. https://www.apache.org/legal/resolved.html#weak-copyleft-licenses

[GitHub] [plc4x] chrisdutz merged pull request #223: Updated Notice and License files.

Posted by GitBox <gi...@apache.org>.
chrisdutz merged pull request #223:
URL: https://github.com/apache/plc4x/pull/223


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [plc4x] chrisdutz commented on a change in pull request #223: Updated Notice and License files.

Posted by GitBox <gi...@apache.org>.
chrisdutz commented on a change in pull request #223:
URL: https://github.com/apache/plc4x/pull/223#discussion_r558948467



##########
File path: pom.xml
##########
@@ -679,10 +679,13 @@
             <!-- License Files for other licenses -->
             <exclude>**/UNLICENSE</exclude>
             <!--
-              Explicitly exclude this file as I was unable
-              to add a new license to the configuration.
+              Explicitly exclude these files as I was unable
+              to add a new licenses to the configuration.
             -->
             <exclude>**/Expression.g4</exclude>
+            <exclude>**/KeyStoreLoader.java</exclude>
+            <exclude>**/OPCUAServer.java</exclude>
+            <exclude>**/Plc4xNamespace.java</exclude>

Review comment:
       Actually you shouldn't need these exclusions. The rat tool should detect the EPL header. But it doesn't harm either.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org