[GitHub] [helix] dasahcc commented on a change in pull request #1650: Improve auto enter maintenance mode

[GitBox <gi...@apache.org>]

dasahcc commented on a change in pull request #1650:
URL: https://github.com/apache/helix/pull/1650#discussion_r578832424



##########
File path: helix-core/src/main/java/org/apache/helix/controller/stages/IntermediateStateCalcStage.java
##########
@@ -239,11 +239,14 @@ private void validateMaxPartitionsPerInstance(ClusterEvent event,
           // in this instance
           partitionCount++;
           if (partitionCount > maxPartitionPerInstance) {
+            // Enable maintenance rebalancer for this pipeline
+            cache.enableMaintenanceMode();

Review comment:
       This could not be very useful. Because it is the stage after BestPossible. And the flag will be read in the cache read stage. Since we are not changing the place to add ZNode of maintenance mode. Let's try to minimize the code change.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org