[jira] [Commented] (TEZ-3551) FrameworkClient created twice causing minor delay

["Siddharth Seth (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TEZ-3551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15811025#comment-15811025 ] 

Siddharth Seth commented on TEZ-3551:
-------------------------------------

That sounds good to me. One thing in the patch is the YarnConfiguration creation. Should this be moved to a point where the FrameworkClient is actually created? or use the one from AMConfiguration itself.

Reading through the existing code, we don't do a great job of enforcing a stop. It looks like a TezClient which has been stopped, can be used again - and will result in a strange error, rather than something useful like "Cannot use a closed client". Haven't really seen any issues around this yet though. 

> FrameworkClient created twice causing minor delay 
> --------------------------------------------------
>
>                 Key: TEZ-3551
>                 URL: https://issues.apache.org/jira/browse/TEZ-3551
>             Project: Apache Tez
>          Issue Type: Improvement
>            Reporter: Rajesh Balamohan
>            Assignee: Rajesh Balamohan
>            Priority: Minor
>         Attachments: TEZ-3551.1.patch, TEZ-3551.2.patch, TEZ-3551.3.patch, TEZ-3551.sameas.2.patch, test_result.txt
>
>
> When tez session is created, it already starts up a framework client.
> https://github.com/apache/tez/blob/master/tez-api/src/main/java/org/apache/tez/client/TezClient.java#L383
> https://github.com/apache/tez/blob/master/tez-api/src/main/java/org/apache/tez/dag/api/client/DAGClientImpl.java#L89
> When DAG is submitted, this frameworkclient is ignored and it ends up creating a new FrameworkClient again causing around 100ms delay which becomes substantial in sub-second execution jobs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)