You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by si...@apache.org on 2019/07/26 04:23:21 UTC

[pulsar] branch master updated: Fix: Messages don't get acked if there is not sink topic (#4815)

This is an automated email from the ASF dual-hosted git repository.

sijie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git


The following commit(s) were added to refs/heads/master by this push:
     new 19b883b  Fix: Messages don't get acked if there is not sink topic (#4815)
19b883b is described below

commit 19b883b7e86e61ba071e230e7f5c6617089dff59
Author: Boyang Jerry Peng <je...@gmail.com>
AuthorDate: Thu Jul 25 21:23:15 2019 -0700

    Fix: Messages don't get acked if there is not sink topic (#4815)
    
    ### Motivation
    
    A message doesn't get automatically ACKed if there is the output topic is not set
---
 .../main/java/org/apache/pulsar/functions/sink/PulsarSinkDisable.java   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/sink/PulsarSinkDisable.java b/pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/sink/PulsarSinkDisable.java
index 8d71313..da15d3b 100644
--- a/pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/sink/PulsarSinkDisable.java
+++ b/pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/sink/PulsarSinkDisable.java
@@ -43,7 +43,7 @@ public class PulsarSinkDisable<T> implements Sink<T> {
 
     @Override
     public void write(Record<T> record) throws Exception {
-        // No-op
+        record.ack();
     }
 
 }