You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2021/01/18 02:13:33 UTC
[GitHub] [servicecomb-service-center] xzccfzy opened a new pull request #830: fix dep rule
xzccfzy opened a new pull request #830:
URL: https://github.com/apache/servicecomb-service-center/pull/830
Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
- [ ] Never comment source code, delete it.
- [ ] UT should has "context, subject, expected result" result as test case name, when you call t.Run().
---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-service-center] tianxiaoliang commented on pull request #830: fix dep rule
Posted by GitBox <gi...@apache.org>.
tianxiaoliang commented on pull request #830:
URL: https://github.com/apache/servicecomb-service-center/pull/830#issuecomment-761938772
冲突，另外这个提交信息量太小了，仔细描述下自己做了哪些事
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-service-center] tianxiaoliang edited a comment on pull request #830: fix dep rule
Posted by GitBox <gi...@apache.org>.
tianxiaoliang edited a comment on pull request #830:
URL: https://github.com/apache/servicecomb-service-center/pull/830#issuecomment-761938772
冲突，另外这个提交信息量太小了，仔细描述下做了哪些事，变更
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-service-center] robotLJW commented on pull request #830: fix dep rule
Posted by GitBox <gi...@apache.org>.
robotLJW commented on pull request #830:
URL: https://github.com/apache/servicecomb-service-center/pull/830#issuecomment-762547280
2 个 Commits得合并成一个
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-service-center] xzccfzy commented on pull request #830: fix dep rule
Posted by GitBox <gi...@apache.org>.
xzccfzy commented on pull request #830:
URL: https://github.com/apache/servicecomb-service-center/pull/830#issuecomment-762551408
> 冲突，另外这个提交信息量太小了，仔细描述下做了哪些事，变更。不要提供几乎无信息量的提交信息
亮哥，commit信息已修改。
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-service-center] tianxiaoliang merged pull request #830: fix dep rule
Posted by GitBox <gi...@apache.org>.
tianxiaoliang merged pull request #830:
URL: https://github.com/apache/servicecomb-service-center/pull/830
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-service-center] tianxiaoliang edited a comment on pull request #830: fix dep rule
Posted by GitBox <gi...@apache.org>.
tianxiaoliang edited a comment on pull request #830:
URL: https://github.com/apache/servicecomb-service-center/pull/830#issuecomment-761938772
冲突，另外这个提交信息量太小了，仔细描述下做了哪些事，变更。不要提供几乎无信息量的提交信息
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-service-center] xzccfzy commented on pull request #830: fix dep rule
Posted by GitBox <gi...@apache.org>.
xzccfzy commented on pull request #830:
URL: https://github.com/apache/servicecomb-service-center/pull/830#issuecomment-762551245
> 2 个 Commits得合并成一个
ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org