[GitHub] [incubator-nemo] alapha23 commented on a change in pull request #187: [NEMO-324] Distinguish Beam's run and waitUntilFinish methods

[GitBox <gi...@apache.org>]

alapha23 commented on a change in pull request #187: [NEMO-324] Distinguish Beam's run and waitUntilFinish methods
URL: https://github.com/apache/incubator-nemo/pull/187#discussion_r322067083
 
 

 ##########
 File path: client/src/main/java/org/apache/nemo/client/ClientEndpoint.java
 ##########
 @@ -109,20 +114,7 @@ private boolean waitUntilConnected(final long timeout,
    * @return {@code true} if the manager set.
    */
   private boolean waitUntilConnected() {
-    connectionLock.lock();
-    try {
-      if (driverEndpoint.get() == null) {
-        // If the driver endpoint is not connected, wait.
-        driverConnected.await();
-      }
-      return true;
-    } catch (final InterruptedException e) {
-      e.printStackTrace(System.err);
-      Thread.currentThread().interrupt();
-      return false;
-    } finally {
-      connectionLock.unlock();
-    }
+    return waitUntilConnected(0, TimeUnit.MILLISECONDS);
 
 Review comment:
   Do we still need this function now?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services