You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2017/11/28 16:43:41 UTC
[kudu-CR] tablet copy-itest: fix TestMetricsResetAfterRevival pt2
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8665
Change subject: tablet_copy-itest: fix TestMetricsResetAfterRevival pt2
......................................................................
tablet_copy-itest: fix TestMetricsResetAfterRevival pt2
b29c9373471927d3f2dfbdab03a8bd728c73d82f introduced a fix to the flaky
test such that the tablet's state is checked to be RUNNING. It did not
take into account the fact that tablet state metrics are cached, so the
tablet could still be in the process of bootstrapping, while it was
being advertized as a running tablet. As such, when run with 8 stress
threads, this failed 55/100 runs.
This patch addresses this by not caching tablet state. With this, with
stress, this passes 1000/1000 runs.
Change-Id: I06e538cc471d15447a90105a4d6ce25f5a69d2b0
---
M src/kudu/integration-tests/tablet_copy-itest.cc
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/65/8665/1
--
To view, visit http://gerrit.cloudera.org:8080/8665
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I06e538cc471d15447a90105a4d6ce25f5a69d2b0
Gerrit-Change-Number: 8665
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
[kudu-CR] tablet copy-itest: fix TestMetricsResetAfterRevival pt2
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8665 )
Change subject: tablet_copy-itest: fix TestMetricsResetAfterRevival pt2
......................................................................
tablet_copy-itest: fix TestMetricsResetAfterRevival pt2
b29c9373471927d3f2dfbdab03a8bd728c73d82f introduced a fix to the flaky
test such that the tablet's state is checked to be RUNNING. It did not
take into account the fact that tablet state metrics are cached, so the
tablet could still be in the process of bootstrapping, while it was
being advertized as a running tablet. As such, when run with 8 stress
threads, this failed 55/100 runs.
This patch addresses this by not caching tablet state. With this, with
stress, this passes 1000/1000 runs.
Change-Id: I06e538cc471d15447a90105a4d6ce25f5a69d2b0
Reviewed-on: http://gerrit.cloudera.org:8080/8665
Tested-by: Kudu Jenkins
Reviewed-by: Will Berkeley <wd...@gmail.com>
---
M src/kudu/integration-tests/tablet_copy-itest.cc
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Kudu Jenkins: Verified
Will Berkeley: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/8665
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I06e538cc471d15447a90105a4d6ce25f5a69d2b0
Gerrit-Change-Number: 8665
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] tablet copy-itest: fix TestMetricsResetAfterRevival pt2
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/8665 )
Change subject: tablet_copy-itest: fix TestMetricsResetAfterRevival pt2
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8665
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I06e538cc471d15447a90105a4d6ce25f5a69d2b0
Gerrit-Change-Number: 8665
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Tue, 28 Nov 2017 17:30:27 +0000
Gerrit-HasComments: No