You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by benkeen <gi...@git.apache.org> on 2014/11/19 00:26:34 UTC
[GitHub] couchdb-fauxton pull request: Shouldn't throw Ace Editor js error
GitHub user benkeen opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/159
Shouldn't throw Ace Editor js error
To reproduce:
1. Select a database and select the "+ New View" option from the
dropdown on the All Documents item.
2. Click on "Databases" in the left sidebar.
Before, this caused a JS error to occur.
Nightwatch test added to confirm this fix.
Closes COUCHDB-2468
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/benkeen/couchdb-fauxton 2468-ace-editor-js-error
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/159.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #159
----
commit c468cde81336b3cc9e48ff10b143720830094f8f
Author: Benjamin Keen <be...@gmail.com>
Date: 2014-11-18T23:25:27Z
Shouldn't throw Ace Editor js error
To reproduce:
1. Select a database and select the "+ New View" option from the
dropdown on the All Documents item.
2. Click on "Databases" in the left sidebar.
Before, this caused a JS error to occur.
Nightwatch test added to confirm this fix.
Closes COUCHDB-2468
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Shouldn't throw Ace Editor js error
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/159#issuecomment-63694509
Merged as d69b0ed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Shouldn't throw Ace Editor js error
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/159#issuecomment-63633739
please rebase / squash before merging - good work!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Shouldn't throw Ace Editor js error
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/159#discussion_r20551672
--- Diff: app/addons/documents/tests/nightwatch/navigateToNewView.js ---
@@ -0,0 +1,37 @@
+// Licensed under the Apache License, Version 2.0 (the "License"); you may not
+// use this file except in compliance with the License. You may obtain a copy of
+// the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+// WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+// License for the specific language governing permissions and limitations under
+// the License.
+
+module.exports = {
+
+ // this tests that the user is able to just navigate to and from the New View page without errors [it confirms
+ // a bug fix for where the Ace Editor threw a JS error preventing the subsequent page from loading]
+ 'Navigate to and from New View Page' : function (client) {
+ /*jshint multistr: true */
+ var waitTime = 10000,
+ newDatabaseName = client.globals.testDatabaseName,
+ baseUrl = client.globals.baseUrl;
+
+ client
+ .loginToGUI()
+ .url(baseUrl+'/#/database/'+newDatabaseName+'/_all_docs')
+ .waitForElementPresent('#new-all-docs-button', waitTime, false)
+ .click('#new-all-docs-button')
+ .waitForElementPresent('#new-all-docs-button a[href="#/database/'+newDatabaseName+'/new_view"]', waitTime, false)
--- End diff --
can you add a space between the `+` and all others in the file (will not mark them with a comment)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Shouldn't throw Ace Editor js error
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/159
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Shouldn't throw Ace Editor js error
Posted by michellephung <gi...@git.apache.org>.
Github user michellephung commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/159#issuecomment-63570690
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Shouldn't throw Ace Editor js error
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/159#discussion_r20551658
--- Diff: app/addons/documents/tests/nightwatch/navigateToNewView.js ---
@@ -0,0 +1,37 @@
+// Licensed under the Apache License, Version 2.0 (the "License"); you may not
+// use this file except in compliance with the License. You may obtain a copy of
+// the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+// WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+// License for the specific language governing permissions and limitations under
+// the License.
+
+module.exports = {
+
+ // this tests that the user is able to just navigate to and from the New View page without errors [it confirms
+ // a bug fix for where the Ace Editor threw a JS error preventing the subsequent page from loading]
+ 'Navigate to and from New View Page' : function (client) {
+ /*jshint multistr: true */
+ var waitTime = 10000,
+ newDatabaseName = client.globals.testDatabaseName,
+ baseUrl = client.globals.baseUrl;
+
+ client
+ .loginToGUI()
+ .url(baseUrl+'/#/database/'+newDatabaseName+'/_all_docs')
--- End diff --
can you add a space between the `+`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Shouldn't throw Ace Editor js error
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/159#discussion_r20551608
--- Diff: app/addons/documents/tests/nightwatch/navigateToNewView.js ---
@@ -0,0 +1,37 @@
+// Licensed under the Apache License, Version 2.0 (the "License"); you may not
+// use this file except in compliance with the License. You may obtain a copy of
+// the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+// WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+// License for the specific language governing permissions and limitations under
+// the License.
+
+module.exports = {
+
+ // this tests that the user is able to just navigate to and from the New View page without errors [it confirms
+ // a bug fix for where the Ace Editor threw a JS error preventing the subsequent page from loading]
+ 'Navigate to and from New View Page' : function (client) {
+ /*jshint multistr: true */
--- End diff --
I think we have no multiline-string in this file
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Shouldn't throw Ace Editor js error
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/159#issuecomment-63665140
Thanks for the reminder! :) Will do.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Shouldn't throw Ace Editor js error
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/159#issuecomment-63578329
Thanks @robertkowalski! Fixed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Shouldn't throw Ace Editor js error
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/159#issuecomment-63633662
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Shouldn't throw Ace Editor js error
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/159#issuecomment-63570215
Thanks @michellephung, I added your suggestiong. Squishing now...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---