You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by mike-jumper <gi...@git.apache.org> on 2016/08/28 20:41:27 UTC
[GitHub] incubator-guacamole-client pull request #67: GUACAMOLE-93: Move Dockerfile t...
GitHub user mike-jumper opened a pull request:
https://github.com/apache/incubator-guacamole-client/pull/67
GUACAMOLE-93: Move Dockerfile to root of repository.
Unfortunately, unlike the `docker` command, it is not currently possible to set up an automated build within Docker Hub if the build context and `Dockerfile` are in different locations. There is an upstream issue for this (docker/hub-feedback#292), but it is now just over one year old.
This change moves the `Dockerfile` to the root of the repository such that automated builds can actually be configured.
Moving the `Dockerfile` (and fixing `.dockerignore`) initially caused the build to fail due to the MySQL/PostgreSQL extension .jars not being present in the guacamole-auth-jdbc distribution .tar.gz. This is a bug that must have been present since PostgreSQL support was added, and I've addressed this here as well.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mike-jumper/incubator-guacamole-client root-docker
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-guacamole-client/pull/67.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #67
----
commit ced30836a04be0513202ea0d755b75efe3d56583
Author: Michael Jumper <mj...@apache.org>
Date: 2016-08-28T06:19:51Z
GUACAMOLE-93: Move Dockerfile to root of repository.
commit dce39bdc1ee7d7da8c4aa1b938b2ef728460a9f5
Author: Michael Jumper <mj...@apache.org>
Date: 2016-08-28T18:33:19Z
GUACAMOLE-93: Ensure database auth extension .jars are included in dist .tar.gz.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-guacamole-client pull request #67: GUACAMOLE-93: Move Dockerfile t...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-guacamole-client/pull/67
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---