You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by tbouron <gi...@git.apache.org> on 2016/04/06 13:06:52 UTC
[GitHub] brooklyn-ui pull request: BROOKLYN-244: Fix blueprint composer loa...
GitHub user tbouron opened a pull request:
https://github.com/apache/brooklyn-ui/pull/23
BROOKLYN-244: Fix blueprint composer loading issue
This load straight away CodeMirror when launching the composer for the composer tab, removing the requirement on loading the full list of applications contained within the catalog.
When coming from the catalog (editing a catalog item YAML), it will temporarily disable the editor, add an overlay displaying `Loading item...` until the item is full loaded from the REST server and added to the editor. At that point, the overlay will fade out and the editor enable again.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tbouron/brooklyn-ui fix/brooklyn-244
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-ui/pull/23.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #23
----
commit 38e89a53f9335994cff9293b57d5164c380f1d6e
Author: Thomas Bouron <th...@cloudsoftcorp.com>
Date: 2016-04-06T11:01:32Z
BROOKLYN-244: Fix blueprint composer loading issue
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-ui pull request: BROOKLYN-244: Fix blueprint composer loa...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-ui/pull/23
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-ui pull request: BROOKLYN-244: Fix blueprint composer loa...
Posted by tbouron <gi...@git.apache.org>.
Github user tbouron commented on the pull request:
https://github.com/apache/brooklyn-ui/pull/23#issuecomment-206419817
Great, thank @aledsage!
If it gets into 0.9.0, you might also want #24
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-ui pull request: BROOKLYN-244: Fix blueprint composer loa...
Posted by m4rkmckenna <gi...@git.apache.org>.
Github user m4rkmckenna commented on the pull request:
https://github.com/apache/brooklyn-ui/pull/23#issuecomment-206420422
@aledsage +1 to including in the 0.9.0 release
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-ui pull request: BROOKLYN-244: Fix blueprint composer loa...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/brooklyn-ui/pull/23#issuecomment-206419417
Thanks @tbouron and @m4rkmckenna
Merging now. Sounds like something to get into the next 0.9.0 release candidate.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-ui pull request: BROOKLYN-244: Fix blueprint composer loa...
Posted by m4rkmckenna <gi...@git.apache.org>.
Github user m4rkmckenna commented on the pull request:
https://github.com/apache/brooklyn-ui/pull/23#issuecomment-206376464
LGTM
Tested with a simulated 50 kb/s connection ... worked as expected
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---