You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/16 14:43:30 UTC
[GitHub] [arrow-datafusion] mvanschellebeeck opened a new pull request, #4243: Use defaults for ListingOptions builder
mvanschellebeeck opened a new pull request, #4243:
URL: https://github.com/apache/arrow-datafusion/pull/4243
Follow up PR for https://github.com/apache/arrow-datafusion/issues/4178
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #4243: Use defaults for ListingOptions builder
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #4243:
URL: https://github.com/apache/arrow-datafusion/pull/4243#issuecomment-1317587982
Benchmark runs are scheduled for baseline = b935cff812418df3096a552eeaa3fddf2193d2ff and contender = 715ed5dd5c6b81bf3c1f40b111642bfb145685e8. 715ed5dd5c6b81bf3c1f40b111642bfb145685e8 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/172565104d54404f9941f367af0cc29e...9dadc5c2759e4332a90e411108d8f1cf/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/0dd8a7f82aef46da9ce4f38433e4f031...3f292868da574a33908cd40eb7603d75/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/701493cee1a64c678b411341fbdfa3ef...34dc87434cd94f46860c9bb00fa69451/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/e3e615f33e6d45a7b7994f0eaea7b073...6d1a4b8f1580410db81d532bb7b02b01/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] mvanschellebeeck commented on pull request #4243: Use defaults for ListingOptions builder
Posted by GitBox <gi...@apache.org>.
mvanschellebeeck commented on PR #4243:
URL: https://github.com/apache/arrow-datafusion/pull/4243#issuecomment-1317223802
Tagging @alamb since this is related to the previous ListingOptions PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] mvanschellebeeck commented on pull request #4243: Use defaults for ListingOptions builder
Posted by GitBox <gi...@apache.org>.
mvanschellebeeck commented on PR #4243:
URL: https://github.com/apache/arrow-datafusion/pull/4243#issuecomment-1317207074
Side note: running ` ./dev/rust_lint.sh` locally showed a bunch of clippy errors - filed #4245
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #4243: Use defaults for ListingOptions builder
Posted by GitBox <gi...@apache.org>.
alamb merged PR #4243:
URL: https://github.com/apache/arrow-datafusion/pull/4243
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #4243: Use defaults for ListingOptions builder
Posted by GitBox <gi...@apache.org>.
alamb commented on code in PR #4243:
URL: https://github.com/apache/arrow-datafusion/pull/4243#discussion_r1024264617
##########
datafusion/core/tests/sql/parquet.rs:
##########
@@ -72,10 +72,10 @@ async fn parquet_with_sort_order_specified() {
})
.collect::<Vec<_>>();
- let options_sort = ListingOptions {
- file_sort_order: Some(file_sort_order),
- ..parquet_read_options.to_listing_options(target_partitions)
- };
+ let options_sort = ListingOptions::from_options(
Review Comment:
same comment as above
##########
datafusion/core/src/datasource/listing/table.rs:
##########
@@ -773,10 +788,9 @@ mod tests {
];
for (file_sort_order, expected_result) in cases {
- let options = ListingOptions {
- file_sort_order,
- ..options.clone()
- };
+ let options = ListingOptions::from_options(options.clone())
+ .with_file_sort_order(file_sort_order);
Review Comment:
Would this work? I think we can avoid adding `from_options`
```suggestion
let options = options.clone()
.with_file_sort_order(file_sort_order);
```
##########
datafusion/core/tests/sql/parquet.rs:
##########
@@ -57,10 +57,10 @@ async fn parquet_with_sort_order_specified() {
let target_partitions = 2;
// The sort order is not specified
- let options_no_sort = ListingOptions {
- file_sort_order: None,
- ..parquet_read_options.to_listing_options(target_partitions)
- };
+ let options_no_sort = ListingOptions::from_options(
+ parquet_read_options.to_listing_options(target_partitions),
+ )
+ .with_file_sort_order(None);
Review Comment:
```suggestion
let options_no_sort = parquet_read_options
.to_listing_options(target_partitions)
.with_file_sort_order(None);
```
##########
datafusion/core/src/datasource/listing/table.rs:
##########
@@ -254,6 +249,26 @@ impl ListingOptions {
file_sort_order: None,
}
}
+
+ /// Build ListingOptions from an existing set of ListingOptions
Review Comment:
I think typically in rust one uses `options.clone()` for this operation
I will leave a comment at the usage site
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] mvanschellebeeck commented on a diff in pull request #4243: Use defaults for ListingOptions builder
Posted by GitBox <gi...@apache.org>.
mvanschellebeeck commented on code in PR #4243:
URL: https://github.com/apache/arrow-datafusion/pull/4243#discussion_r1024368430
##########
datafusion/core/src/datasource/listing/table.rs:
##########
@@ -254,6 +249,26 @@ impl ListingOptions {
file_sort_order: None,
}
}
+
+ /// Build ListingOptions from an existing set of ListingOptions
Review Comment:
yep, that makes a lot more sense!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org