You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jclouds.apache.org by Zack Shoylev <no...@github.com> on 2013/10/11 19:26:11 UTC
[jclouds] JCLOUDS-332 Skips tests broken on windows (#175)
backport
You can merge this Pull Request by running:
git pull https://github.com/rackspace/jclouds skip-windows-tests-backport
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/175
-- Commit Summary --
* JCLOUDS-332 Skips tests broken on windows
-- File Changes --
M apis/filesystem/src/test/java/org/jclouds/filesystem/integration/FilesystemContainerIntegrationTestDisabled.java (90)
M apis/filesystem/src/test/java/org/jclouds/filesystem/utils/TestUtils.java (7)
M blobstore/src/test/java/org/jclouds/blobstore/integration/internal/BaseBlobIntegrationTest.java (6)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/175.patch
https://github.com/jclouds/jclouds/pull/175.diff
Re: [jclouds] JCLOUDS-332 Skips tests broken on windows (#175)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #820](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/820/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/175#issuecomment-27400087
Re: [jclouds] JCLOUDS-332 Skips tests broken on windows (#175)
Posted by Zack Shoylev <no...@github.com>.
> @@ -454,8 +454,12 @@ public void blobNotFound() throws InterruptedException {
>
> @DataProvider(name = "delete")
> public Object[][] createData() {
> - return new Object[][] { { "normal" }, { "sp ace" }, { "qu?stion" }, { "unic₪de" }, { "path/foo" }, { "colon:" },
> + if (System.getProperty("os.name").toLowerCase().contains("windows")) {
> + return new Object[][] { { "normal" }, { "sp ace" } };
Different tests I believe
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/175/files#r7298704
Re: [jclouds] JCLOUDS-332 Skips tests broken on windows (#175)
Posted by Zack Shoylev <no...@github.com>.
Fixed the weird line split, will merge after tests pass, unless I get more comments.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/175#issuecomment-27397830
Re: [jclouds] JCLOUDS-332 Skips tests broken on windows (#175)
Posted by Zack Shoylev <no...@github.com>.
I think I figured it out. Will try to fix.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/175#issuecomment-27216432
Re: [jclouds] JCLOUDS-332 Skips tests broken on windows (#175)
Posted by Zack Shoylev <no...@github.com>.
> @@ -95,4 +101,64 @@ public void testDirectory() throws InterruptedException {
> public void testWithDetails() throws InterruptedException, IOException {
> throw new SkipException("not yet implemented");
> }
> +
> + @Override
> + @Test(dataProvider = "ignoreOnWindows")
I have not debugged this set of tests.. so no idea. I can maybe have another look once I finish fixing autoscale.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/175/files#r7298737
Re: [jclouds] JCLOUDS-332 Skips tests broken on windows (#175)
Posted by Zack Shoylev <no...@github.com>.
Closed #175.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/175
Re: [jclouds] JCLOUDS-332 Skips tests broken on windows (#175)
Posted by Andrew Phillips <no...@github.com>.
Thanks for answering my main question, @zack-shoylev! +1 - good to go for me!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/175#issuecomment-27364118
Re: [jclouds] JCLOUDS-332 Skips tests broken on windows (#175)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #500](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/500/) FAILURE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/175#issuecomment-26155183
Re: [jclouds] JCLOUDS-332 Skips tests broken on windows (#175)
Posted by Andrew Phillips <no...@github.com>.
> @@ -95,4 +101,64 @@ public void testDirectory() throws InterruptedException {
> public void testWithDetails() throws InterruptedException, IOException {
> throw new SkipException("not yet implemented");
> }
> +
> + @Override
> + @Test(dataProvider = "ignoreOnWindows")
Add some comments somewhere as to _why_ these are failing on Windows, if we know?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/175/files#r7297039
Re: [jclouds] JCLOUDS-332 Skips tests broken on windows (#175)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #297](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/297/) FAILURE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/175#issuecomment-26155266
Re: [jclouds] JCLOUDS-332 Skips tests broken on windows (#175)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #357](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/357/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/175#issuecomment-27400465
Re: [jclouds] JCLOUDS-332 Skips tests broken on windows (#175)
Posted by Andrew Phillips <no...@github.com>.
> I think I figured it out. Will try to fix.
Thanks, @zack-shoylev!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/175#issuecomment-27218753
Re: [jclouds] JCLOUDS-332 Skips tests broken on windows (#175)
Posted by Andrew Phillips <no...@github.com>.
[Failures](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/297/console) are real - merge issue.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/175#issuecomment-26196828
Re: [jclouds] JCLOUDS-332 Skips tests broken on windows (#175)
Posted by Andrew Phillips <no...@github.com>.
> @@ -454,8 +454,12 @@ public void blobNotFound() throws InterruptedException {
>
> @DataProvider(name = "delete")
> public Object[][] createData() {
> - return new Object[][] { { "normal" }, { "sp ace" }, { "qu?stion" }, { "unic₪de" }, { "path/foo" }, { "colon:" },
> + if (System.getProperty("os.name").toLowerCase().contains("windows")) {
> + return new Object[][] { { "normal" }, { "sp ace" } };
Wait...we're already limiting the input for Windows and it _still_ fails? If we're going to skip tests, why not keep the original input set?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/175/files#r7297059
Re: [jclouds] JCLOUDS-332 Skips tests broken on windows (#175)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #356](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/356/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/175#issuecomment-27341183
Re: [jclouds] JCLOUDS-332 Skips tests broken on windows (#175)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #759](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/759/) FAILURE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/175#issuecomment-26155242
Re: [jclouds] JCLOUDS-332 Skips tests broken on windows (#175)
Posted by Andrew Phillips <no...@github.com>.
> String key = "hello";
>
> - // NOTE all metadata in jclouds comes out as lowercase, in an effort to normalize the
> + // NOTE all metadata in jclouds comes out as lowercase, in an effort to
> + // normalize the
> // providers.
[minor] Weird line split now? Back to two lines?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/175/files#r7297007
Re: [jclouds] JCLOUDS-332 Skips tests broken on windows (#175)
Posted by Andrew Phillips <no...@github.com>.
+1 for the code itself, only a couple of minor comments there. Main comment is whether we still need to restrict the input data for Windows if we're then _also_ going to go and skip most of the tests..?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/175#issuecomment-27349571
Re: [jclouds] JCLOUDS-332 Skips tests broken on windows (#175)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #566](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/566/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/175#issuecomment-27403877
Re: [jclouds] JCLOUDS-332 Skips tests broken on windows (#175)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #819](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/819/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/175#issuecomment-27341202