You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/07/08 20:37:19 UTC
[GitHub] [incubator-pinot] npawar commented on a change in pull request
#4396: make kafka version number controlled by config number
npawar commented on a change in pull request #4396: make kafka version number controlled by config number
URL: https://github.com/apache/incubator-pinot/pull/4396#discussion_r301288628
##########
File path: pinot-integration-tests/pom.xml
##########
@@ -192,7 +192,7 @@
<!-- TODO: figure out a way to avoid explicitly setting the kafka module dependency, and instead inject it, such that any kafka stream implementation can use this -->
Review comment:
Thanks for this change!
Please remove this TODO from the pom.xml in pinot-intergation-tests, pinot-tools, pinot-perf, and put it in the main pom.xml
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org