[jira] Commented: (ROL-1733) Implement OpenID for Roller

["David Johnson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/roller/browse/ROL-1733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14384#action_14384 ] 

David Johnson commented on ROL-1733:
------------------------------------

Here are some comments on the 1st patch (July 8, 2008)

* createdb.vm
- New table should be named roller_userattibute to match Roller conventions
- Also need to add table to 400-to-410-migration.vm script

* build.xml / properties.xmlf
- Put new OpenID jars in directory tools/openid4java

* JPAUserManagerImpl
- Adding logic to getUserByUserName() does not seem like the right approach
  How about getUserWithAttributeValue(String attrName, String attrValue)?
- No need for new query "User.getById" -- that's what getUserById() does

* Login.jsp
- Need to add I18N strings to WEB-INF/classes/ApplicationResources.properties

* User.java
- It's not clear that we need add a user attributes array here



> Implement OpenID for Roller
> ---------------------------
>
>                 Key: ROL-1733
>                 URL: https://issues.apache.org/roller/browse/ROL-1733
>             Project: Roller
>          Issue Type: New Feature
>          Components: User Management
>            Reporter: David Johnson
>            Assignee: Roller Unassigned
>         Attachments: ROL-1733.patch
>
>
> Represents this proposal:
>    http://cwiki.apache.org/confluence/display/ROLLER/Proposal+OpenID+Support

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.