You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/12/11 15:23:22 UTC
[GitHub] [iotdb] ycycse opened a new pull request, #8411: [IOTDB-5172] Fix SingleDeviceViewNode can't get outputColumnTypes when it's isolated
ycycse opened a new pull request, #8411:
URL: https://github.com/apache/iotdb/pull/8411
1. add cacheOutputColumnNames to SingleDeviceViewNode to judge if the Node should cache outputColumnNames
2. currently the fix refers to code changing of visitMergeSort in ExchangeNodeAdder. May be there is a better way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] JackieTien97 commented on a diff in pull request #8411: [IOTDB-5172] Fix SingleDeviceViewNode can't get outputColumnTypes when it's isolated
Posted by GitBox <gi...@apache.org>.
JackieTien97 commented on code in PR #8411:
URL: https://github.com/apache/iotdb/pull/8411#discussion_r1045339825
##########
server/src/main/java/org/apache/iotdb/db/mpp/plan/planner/plan/node/process/SingleDeviceViewNode.java:
##########
@@ -36,10 +36,12 @@ public class SingleDeviceViewNode extends SingleChildProcessNode {
private final String device;
// To reduce memory cost, SingleDeviceViewNode doesn't serialize and deserialize
- // outputColumnNames.
- // It just rebuilds using the infos from parent node.
- private List<String> outputColumnNames;
+ // outputColumnNames.It just rebuilds using the infos from parent node.
+ private final List<String> outputColumnNames;
private final List<Integer> deviceToMeasurementIndexes;
+ // For some isolated SingleDeviceViewNodes without parent node, they need to cache
+ // the outputColumnNames themselves.
+ private boolean cacheOutputColumnNames = false;
Review Comment:
Add another UT case to test serialize and deserialize for SingleDeviceViewNode when `cacheOutputColumnNames` is `true`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] JackieTien97 merged pull request #8411: [IOTDB-5172] Fix SingleDeviceViewNode can't get outputColumnTypes when it's isolated
Posted by GitBox <gi...@apache.org>.
JackieTien97 merged PR #8411:
URL: https://github.com/apache/iotdb/pull/8411
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] ycycse commented on a diff in pull request #8411: [IOTDB-5172] Fix SingleDeviceViewNode can't get outputColumnTypes when it's isolated
Posted by GitBox <gi...@apache.org>.
ycycse commented on code in PR #8411:
URL: https://github.com/apache/iotdb/pull/8411#discussion_r1045365198
##########
server/src/main/java/org/apache/iotdb/db/mpp/plan/planner/plan/node/process/SingleDeviceViewNode.java:
##########
@@ -36,10 +36,12 @@ public class SingleDeviceViewNode extends SingleChildProcessNode {
private final String device;
// To reduce memory cost, SingleDeviceViewNode doesn't serialize and deserialize
- // outputColumnNames.
- // It just rebuilds using the infos from parent node.
- private List<String> outputColumnNames;
+ // outputColumnNames.It just rebuilds using the infos from parent node.
+ private final List<String> outputColumnNames;
private final List<Integer> deviceToMeasurementIndexes;
+ // For some isolated SingleDeviceViewNodes without parent node, they need to cache
+ // the outputColumnNames themselves.
+ private boolean cacheOutputColumnNames = false;
Review Comment:
UT has been added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org