You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/09/16 14:29:27 UTC

[GitHub] [flink] TisonKun commented on issue #9684: [FLINK-13992][coordination] Refactor Optional parameter in InputGateWithMetrics#updateMetrics

TisonKun commented on issue #9684: [FLINK-13992][coordination] Refactor Optional parameter in InputGateWithMetrics#updateMetrics
URL: https://github.com/apache/flink/pull/9684#issuecomment-531803145
 
 
   Thanks for your review @azagrebin!
   
   I'm not very sure about your addition. IMO it is good to separate code style changes with feature efforts. In your words it seems you also agree this opinion but there is an "although" and following this statement
   
   > The small code style improvements are not associated with any feature efforts and clutter the history which makes understanding the original reason for the code lines harder.
   
   What best practice do you suggest here exactly? Could you explain a bit?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services