[GitHub] [beam] AnandInguva commented on a diff in pull request #27689: Add instructions on adding new Actions workflows

["AnandInguva (via GitHub)" <gi...@apache.org>]

AnandInguva commented on code in PR #27689:
URL: https://github.com/apache/beam/pull/27689#discussion_r1275139621


##########
.github/workflows/README.md:
##########
@@ -14,6 +14,87 @@
     specific language governing permissions and limitations
     under the License.
 -->
+
+# Guidelines for Adding or Modifying Workflows
+
+On top of normal Actions workflow steps, all new CI workflows (excluding release workflows or other workflow automation) should have the following:
+
+1) A set of specific triggers
+2) An explicit checkout step

Review Comment:
   Does this checkout merges the PR with the master branch? If the user code is old, the test might fail with old errors that are already fixed on master



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org