[GitHub] [apisix] swayamraina commented on a change in pull request #2221: send file contents and not file name

[GitBox <gi...@apache.org>]

swayamraina commented on a change in pull request #2221:
URL: https://github.com/apache/apisix/pull/2221#discussion_r490512498



##########
File path: apisix/utils/log-util.lua
##########
@@ -64,7 +64,11 @@ local function get_full_log(ngx, conf)
         else
             local body_file = ngx.req.get_body_file()
             if body_file then
-                log.request.body_file = body_file
+                local lines = {}

Review comment:
       `if not file then return nil end`
   do we need this part of the code? if the body is not present then can we not assume the data will be present in the file?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org