[jira] [Comment Edited] (WICKET-4664) Url#getQueryString(charset) method returns quesrystring with "?" prefixed to it

["vineet semwal (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WICKET-4664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13645426#comment-13645426 ] 

vineet semwal edited comment on WICKET-4664 at 4/30/13 10:13 AM:
-----------------------------------------------------------------

aha i nearly forgot this issue ...
since the change is scheduled for 7.0 ,i think it will be good to have getQueryString methods without "?" itself .. ,one way would be to rename current methods and help IDE refactor and later add getQueryString methods which returns value which does not start with "?" 

edit: i made a little typo so corrected it 
@cederic : i agree with you ,not sure how much things will it break ..
                
      was (Author: vineetsemwal):
    aha i nearly forgot this issue ...
since the change is scheduled for 7.0 ,i think it will be good to have getQueryString methods without "?" itself .. ,one way would be to rename current methods and help IDE refactor and later add getQueryString methods with does not start with "?" 
                  
> Url#getQueryString(charset) method returns quesrystring with "?" prefixed to it
> -------------------------------------------------------------------------------
>
>                 Key: WICKET-4664
>                 URL: https://issues.apache.org/jira/browse/WICKET-4664
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 6.0.0-beta3
>            Reporter: vineet semwal
>             Fix For: 7.0
>
>
> i have just pointed out 6.0.0-beta3/6.x but it must be same in 1.5.x too ,afaik "?" is not considered part of querystring ,"?" is considered separator see http://tools.ietf.org/html/rfc3986#section-3
> this method is used in Url#toString() too which can be easily fixed but it may be used at other places too so i don't know if removing "?" will break things now.
> so how things break currently
> RequestUtils.decodeParameters(url.getQueryString(),parameters);
> decodeparameters will considered first key to be "?key" 
> so may be requestutils#decodeparameters method should strip away "?" if it's present in the query string before populating pageparameters
> thanks!

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira