You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by pi...@apache.org on 2023/03/06 21:47:00 UTC
[airflow] 16/37: Add dep context description for better log message (#28875)
This is an automated email from the ASF dual-hosted git repository.
pierrejeambrun pushed a commit to branch v2-5-test
in repository https://gitbox.apache.org/repos/asf/airflow.git
commit 8719079355fa27b56329a90b153b9acbf53c6eff
Author: Daniel Standish <15...@users.noreply.github.com>
AuthorDate: Wed Jan 11 23:56:49 2023 -0800
Add dep context description for better log message (#28875)
Otherwise, it appears that there is a duplicate log record.
(cherry picked from commit 1ca94ee6ba767ed6851858db24319aa1008562eb)
---
airflow/models/taskinstance.py | 4 +++-
airflow/ti_deps/dep_context.py | 1 +
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/airflow/models/taskinstance.py b/airflow/models/taskinstance.py
index 9708d73124..f237fe35e3 100644
--- a/airflow/models/taskinstance.py
+++ b/airflow/models/taskinstance.py
@@ -1080,7 +1080,7 @@ class TaskInstance(Base, LoggingMixin):
if failed:
return False
- verbose_aware_logger("Dependencies all met for %s", self)
+ verbose_aware_logger("Dependencies all met for dep_context=%s ti=%s", dep_context.description, self)
return True
@provide_session
@@ -1230,6 +1230,7 @@ class TaskInstance(Base, LoggingMixin):
ignore_ti_state=ignore_ti_state,
ignore_depends_on_past=ignore_depends_on_past,
ignore_task_deps=ignore_task_deps,
+ description="non-requeueable deps",
)
if not self.are_dependencies_met(
dep_context=non_requeueable_dep_context, session=session, verbose=True
@@ -1258,6 +1259,7 @@ class TaskInstance(Base, LoggingMixin):
ignore_depends_on_past=ignore_depends_on_past,
ignore_task_deps=ignore_task_deps,
ignore_ti_state=ignore_ti_state,
+ description="requeueable deps",
)
if not self.are_dependencies_met(dep_context=dep_context, session=session, verbose=True):
self.state = State.NONE
diff --git a/airflow/ti_deps/dep_context.py b/airflow/ti_deps/dep_context.py
index 829e396417..5ddecb21c7 100644
--- a/airflow/ti_deps/dep_context.py
+++ b/airflow/ti_deps/dep_context.py
@@ -73,6 +73,7 @@ class DepContext:
ignore_ti_state: bool = False
ignore_unmapped_tasks: bool = False
finished_tis: list[TaskInstance] | None = None
+ description: str | None = None
have_changed_ti_states: bool = False
"""Have any of the TIs state's been changed as a result of evaluating dependencies"""