You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@climate.apache.org by "Cameron Goodale (JIRA)" <ji...@apache.org> on 2013/07/25 17:23:49 UTC
[jira] [Resolved] (CLIMATE-110) Pull the 'raw_input' functions out
of the metrics.calcPdf function
[ https://issues.apache.org/jira/browse/CLIMATE-110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Cameron Goodale resolved CLIMATE-110.
-------------------------------------
Resolution: Fixed
Fix Version/s: (was: 0.2-incubating)
0.1-incubating
Committed revision 1507011.
> Pull the 'raw_input' functions out of the metrics.calcPdf function
> ------------------------------------------------------------------
>
> Key: CLIMATE-110
> URL: https://issues.apache.org/jira/browse/CLIMATE-110
> Project: Apache Open Climate Workbench
> Issue Type: Bug
> Components: metrics
> Affects Versions: 0.1-incubating
> Reporter: Cameron Goodale
> Assignee: Cameron Goodale
> Fix For: 0.1-incubating
>
> Original Estimate: 2h
> Time Spent: 2h
> Remaining Estimate: 0h
>
> While reviewing a recent Review Board for metrics.py I noticed we have several raw_input() functions within the calcPdf function.
> nbins = int (raw_input('Please enter the number of bins to use. \n'))
> minEdge = float(raw_input('Please enter the minimum value to use for the edge. \n'))
> maxEdge = float(raw_input('Please enter the maximum value to use for the edge. \n'))
> These parameters should instead be passed into the function by the caller. This will make the code easier to call from an external script or the GUI.
> This should be started once CLIMATE-88 is resolved.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira