[GitHub] rob05c commented on a change in pull request #3317: TO fix anymap ds assignment

[GitBox <gi...@apache.org>]

rob05c commented on a change in pull request #3317: TO fix anymap ds assignment
URL: https://github.com/apache/trafficcontrol/pull/3317#discussion_r255359507
 
 

 ##########
 File path: traffic_ops/traffic_ops_golang/crconfig/servers.go
 ##########
 @@ -190,10 +191,12 @@ select s.host_name, ds.xml_id
 from deliveryservice_server as dss
 inner join server as s on dss.server = s.id
 inner join deliveryservice as ds on ds.id = dss.deliveryservice
+inner join type as dt on dt.id = ds.type
 inner join profile as p on p.id = s.profile
 inner join status as st ON st.id = s.status
 where ds.cdn_id = (select id from cdn where name = $1)
-and ds.active = true
+and ds.active = true` +
+		fmt.Sprintf(" and dt.name != '%s' ", tc.DSTypeAnyMap) + `
 
 Review comment:
   Nitpick: `!=` isn't standard SQL, better to use the standard-compliant `<>`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services