You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2019/12/10 18:07:30 UTC
[kudu-CR] memrowset: small optimizations for scanning
Hello Andrew Wong,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/14874
to review the following change.
Change subject: memrowset: small optimizations for scanning
......................................................................
memrowset: small optimizations for scanning
This adds two small optimizations for MRS/CBTree. They should have a
small (maybe not noticeable) effect on user scans, but hopefully will
also improve the speed of flushing by a few percent, which I found to be
CPU bound when using an NVM disk for storage.
- add a new getter to fetch the stored values without also accessing the
stored keys. In most cases we don't care about the encoded key when
accessing MRS, so we can avoid potentially following the key pointer
(should avoid a cache miss)
Shows a small effect in the modified benchmark:
I1210 10:04:46.209149 15145 cbtree-test.cc:795] Time spent Scan 4000000 keys 10 times (frozen): real 0.638s user 0.636s sys 0.000s
I1210 10:04:46.804275 15145 cbtree-test.cc:806] Time spent Scan 4000000 keys 10 times (frozen, val-only): real 0.595s user 0.596s sys 0.000s
... though this one didn't show a major effect in memrowset-test on its
own.
- add prefetching of the MRS values during scanning
Tested with:
memrowset-test --gtest_filter=\*InsertCount\* --roundtrip_num_rows=10000000 --gtest_repeat=10
t-test for the "all committed" result shows a significant (though <5%) effect:
data: subset(d, V1 == "before")$V2 and subset(d, V1 == "after-prefetch")$V2
t = 3.4999, df = 18, p-value = 0.002557
alternative hypothesis: true difference in means is not equal to 0
95 percent confidence interval:
0.004876512 0.019523488
sample estimates:
mean of x mean of y
0.3622 0.3500
Change-Id: Ia44b34606439625fbbbcc83e3652455a8894a0b3
---
M src/kudu/tablet/cbtree-test.cc
M src/kudu/tablet/concurrent_btree.h
M src/kudu/tablet/memrowset.cc
M src/kudu/tablet/memrowset.h
4 files changed, 59 insertions(+), 16 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/14874/1
--
To view, visit http://gerrit.cloudera.org:8080/14874
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia44b34606439625fbbbcc83e3652455a8894a0b3
Gerrit-Change-Number: 14874
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Andrew Wong <an...@cloudera.com>
[kudu-CR] memrowset: small optimizations for scanning
Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14874 )
Change subject: memrowset: small optimizations for scanning
......................................................................
Patch Set 5: Code-Review+1
(2 comments)
http://gerrit.cloudera.org:8080/#/c/14874/5//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/14874/5//COMMIT_MSG@33
PS5, Line 33: t-test
Curious how do you run a t-test for a given gtest?
http://gerrit.cloudera.org:8080/#/c/14874/5/src/kudu/tablet/cbtree-test.cc
File src/kudu/tablet/cbtree-test.cc:
http://gerrit.cloudera.org:8080/#/c/14874/5/src/kudu/tablet/cbtree-test.cc@759
PS5, Line 759: exact
Nit: Since "exact" is not used, perhaps rename it to unused_exact?
--
To view, visit http://gerrit.cloudera.org:8080/14874
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia44b34606439625fbbbcc83e3652455a8894a0b3
Gerrit-Change-Number: 14874
Gerrit-PatchSet: 5
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <an...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Sat, 18 Jan 2020 00:41:33 +0000
Gerrit-HasComments: Yes
[kudu-CR] memrowset: small optimizations for scanning
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14874 )
Change subject: memrowset: small optimizations for scanning
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14874/1/src/kudu/tablet/cbtree-test.cc
File src/kudu/tablet/cbtree-test.cc:
http://gerrit.cloudera.org:8080/#/c/14874/1/src/kudu/tablet/cbtree-test.cc@754
PS1, Line 754: gscoped_ptr<CBTreeIterator<BTreeTraits> > iter(
Wanna modernize while you're here?
--
To view, visit http://gerrit.cloudera.org:8080/14874
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia44b34606439625fbbbcc83e3652455a8894a0b3
Gerrit-Change-Number: 14874
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <an...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Tue, 10 Dec 2019 18:23:26 +0000
Gerrit-HasComments: Yes
[kudu-CR] memrowset: small optimizations for scanning
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14874 )
Change subject: memrowset: small optimizations for scanning
......................................................................
memrowset: small optimizations for scanning
This adds two small optimizations for MRS/CBTree. They should have a
small (maybe not noticeable) effect on user scans, but hopefully will
also improve the speed of flushing by a few percent, which I found to be
CPU bound when using an NVM disk for storage.
- add a new getter to fetch the stored values without also accessing the
stored keys. In most cases we don't care about the encoded key when
accessing MRS, so we can avoid potentially following the key pointer
(should avoid a cache miss)
Shows a small effect in the modified benchmark:
I1210 10:04:46.209149 15145 cbtree-test.cc:795] Time spent Scan 4000000 keys 10 times (frozen): real 0.638s user 0.636s sys 0.000s
I1210 10:04:46.804275 15145 cbtree-test.cc:806] Time spent Scan 4000000 keys 10 times (frozen, val-only): real 0.595s user 0.596s sys 0.000s
... though this one didn't show a major effect in memrowset-test on its
own.
- add prefetching of the MRS values during scanning
Tested with:
memrowset-test --gtest_filter=\*InsertCount\* --roundtrip_num_rows=10000000 --gtest_repeat=10
t-test for the "all committed" result shows a significant (though <5%) effect:
data: subset(d, V1 == "before")$V2 and subset(d, V1 == "after-prefetch")$V2
t = 3.4999, df = 18, p-value = 0.002557
alternative hypothesis: true difference in means is not equal to 0
95 percent confidence interval:
0.004876512 0.019523488
sample estimates:
mean of x mean of y
0.3622 0.3500
Change-Id: Ia44b34606439625fbbbcc83e3652455a8894a0b3
Reviewed-on: http://gerrit.cloudera.org:8080/14874
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Reviewed-by: Bankim Bhavsar <ba...@cloudera.com>
---
M src/kudu/tablet/cbtree-test.cc
M src/kudu/tablet/concurrent_btree.h
M src/kudu/tablet/memrowset.cc
M src/kudu/tablet/memrowset.h
4 files changed, 83 insertions(+), 36 deletions(-)
Approvals:
Kudu Jenkins: Verified
Adar Dembo: Looks good to me, approved
Bankim Bhavsar: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.cloudera.org:8080/14874
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia44b34606439625fbbbcc83e3652455a8894a0b3
Gerrit-Change-Number: 14874
Gerrit-PatchSet: 6
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <an...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] memrowset: small optimizations for scanning
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Andrew Wong, Kudu Jenkins, Andrew Wong, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14874
to look at the new patch set (#5).
Change subject: memrowset: small optimizations for scanning
......................................................................
memrowset: small optimizations for scanning
This adds two small optimizations for MRS/CBTree. They should have a
small (maybe not noticeable) effect on user scans, but hopefully will
also improve the speed of flushing by a few percent, which I found to be
CPU bound when using an NVM disk for storage.
- add a new getter to fetch the stored values without also accessing the
stored keys. In most cases we don't care about the encoded key when
accessing MRS, so we can avoid potentially following the key pointer
(should avoid a cache miss)
Shows a small effect in the modified benchmark:
I1210 10:04:46.209149 15145 cbtree-test.cc:795] Time spent Scan 4000000 keys 10 times (frozen): real 0.638s user 0.636s sys 0.000s
I1210 10:04:46.804275 15145 cbtree-test.cc:806] Time spent Scan 4000000 keys 10 times (frozen, val-only): real 0.595s user 0.596s sys 0.000s
... though this one didn't show a major effect in memrowset-test on its
own.
- add prefetching of the MRS values during scanning
Tested with:
memrowset-test --gtest_filter=\*InsertCount\* --roundtrip_num_rows=10000000 --gtest_repeat=10
t-test for the "all committed" result shows a significant (though <5%) effect:
data: subset(d, V1 == "before")$V2 and subset(d, V1 == "after-prefetch")$V2
t = 3.4999, df = 18, p-value = 0.002557
alternative hypothesis: true difference in means is not equal to 0
95 percent confidence interval:
0.004876512 0.019523488
sample estimates:
mean of x mean of y
0.3622 0.3500
Change-Id: Ia44b34606439625fbbbcc83e3652455a8894a0b3
---
M src/kudu/tablet/cbtree-test.cc
M src/kudu/tablet/concurrent_btree.h
M src/kudu/tablet/memrowset.cc
M src/kudu/tablet/memrowset.h
4 files changed, 83 insertions(+), 36 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/14874/5
--
To view, visit http://gerrit.cloudera.org:8080/14874
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia44b34606439625fbbbcc83e3652455a8894a0b3
Gerrit-Change-Number: 14874
Gerrit-PatchSet: 5
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <an...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] memrowset: small optimizations for scanning
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/14874 )
Change subject: memrowset: small optimizations for scanning
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/14874/1/src/kudu/tablet/cbtree-test.cc
File src/kudu/tablet/cbtree-test.cc:
http://gerrit.cloudera.org:8080/#/c/14874/1/src/kudu/tablet/cbtree-test.cc@754
PS1, Line 754: gscoped_ptr<CBTreeIterator<BTreeTraits> > iter(
> Wanna modernize while you're here?
Done
http://gerrit.cloudera.org:8080/#/c/14874/1/src/kudu/tablet/cbtree-test.cc@797
PS1, Line 797: int64_t count = 0, total_len = 0;
> warning: multiple declarations in a single statement reduces readability [r
Done
http://gerrit.cloudera.org:8080/#/c/14874/1/src/kudu/tablet/cbtree-test.cc@808
PS1, Line 808: int64_t count = 0, total_len = 0;
> warning: multiple declarations in a single statement reduces readability [r
Done
--
To view, visit http://gerrit.cloudera.org:8080/14874
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia44b34606439625fbbbcc83e3652455a8894a0b3
Gerrit-Change-Number: 14874
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <an...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 16 Jan 2020 21:27:36 +0000
Gerrit-HasComments: Yes
[kudu-CR] memrowset: small optimizations for scanning
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Andrew Wong, Kudu Jenkins, Andrew Wong, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14874
to look at the new patch set (#3).
Change subject: memrowset: small optimizations for scanning
......................................................................
memrowset: small optimizations for scanning
This adds two small optimizations for MRS/CBTree. They should have a
small (maybe not noticeable) effect on user scans, but hopefully will
also improve the speed of flushing by a few percent, which I found to be
CPU bound when using an NVM disk for storage.
- add a new getter to fetch the stored values without also accessing the
stored keys. In most cases we don't care about the encoded key when
accessing MRS, so we can avoid potentially following the key pointer
(should avoid a cache miss)
Shows a small effect in the modified benchmark:
I1210 10:04:46.209149 15145 cbtree-test.cc:795] Time spent Scan 4000000 keys 10 times (frozen): real 0.638s user 0.636s sys 0.000s
I1210 10:04:46.804275 15145 cbtree-test.cc:806] Time spent Scan 4000000 keys 10 times (frozen, val-only): real 0.595s user 0.596s sys 0.000s
... though this one didn't show a major effect in memrowset-test on its
own.
- add prefetching of the MRS values during scanning
Tested with:
memrowset-test --gtest_filter=\*InsertCount\* --roundtrip_num_rows=10000000 --gtest_repeat=10
t-test for the "all committed" result shows a significant (though <5%) effect:
data: subset(d, V1 == "before")$V2 and subset(d, V1 == "after-prefetch")$V2
t = 3.4999, df = 18, p-value = 0.002557
alternative hypothesis: true difference in means is not equal to 0
95 percent confidence interval:
0.004876512 0.019523488
sample estimates:
mean of x mean of y
0.3622 0.3500
Change-Id: Ia44b34606439625fbbbcc83e3652455a8894a0b3
---
M src/kudu/tablet/cbtree-test.cc
M src/kudu/tablet/concurrent_btree.h
M src/kudu/tablet/memrowset.cc
M src/kudu/tablet/memrowset.h
4 files changed, 80 insertions(+), 35 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/14874/3
--
To view, visit http://gerrit.cloudera.org:8080/14874
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia44b34606439625fbbbcc83e3652455a8894a0b3
Gerrit-Change-Number: 14874
Gerrit-PatchSet: 3
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <an...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] memrowset: small optimizations for scanning
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Andrew Wong, Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14874
to look at the new patch set (#2).
Change subject: memrowset: small optimizations for scanning
......................................................................
memrowset: small optimizations for scanning
This adds two small optimizations for MRS/CBTree. They should have a
small (maybe not noticeable) effect on user scans, but hopefully will
also improve the speed of flushing by a few percent, which I found to be
CPU bound when using an NVM disk for storage.
- add a new getter to fetch the stored values without also accessing the
stored keys. In most cases we don't care about the encoded key when
accessing MRS, so we can avoid potentially following the key pointer
(should avoid a cache miss)
Shows a small effect in the modified benchmark:
I1210 10:04:46.209149 15145 cbtree-test.cc:795] Time spent Scan 4000000 keys 10 times (frozen): real 0.638s user 0.636s sys 0.000s
I1210 10:04:46.804275 15145 cbtree-test.cc:806] Time spent Scan 4000000 keys 10 times (frozen, val-only): real 0.595s user 0.596s sys 0.000s
... though this one didn't show a major effect in memrowset-test on its
own.
- add prefetching of the MRS values during scanning
Tested with:
memrowset-test --gtest_filter=\*InsertCount\* --roundtrip_num_rows=10000000 --gtest_repeat=10
t-test for the "all committed" result shows a significant (though <5%) effect:
data: subset(d, V1 == "before")$V2 and subset(d, V1 == "after-prefetch")$V2
t = 3.4999, df = 18, p-value = 0.002557
alternative hypothesis: true difference in means is not equal to 0
95 percent confidence interval:
0.004876512 0.019523488
sample estimates:
mean of x mean of y
0.3622 0.3500
Change-Id: Ia44b34606439625fbbbcc83e3652455a8894a0b3
---
M src/kudu/tablet/cbtree-test.cc
M src/kudu/tablet/concurrent_btree.h
M src/kudu/tablet/memrowset.cc
M src/kudu/tablet/memrowset.h
4 files changed, 80 insertions(+), 35 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/14874/2
--
To view, visit http://gerrit.cloudera.org:8080/14874
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia44b34606439625fbbbcc83e3652455a8894a0b3
Gerrit-Change-Number: 14874
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <an...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] memrowset: small optimizations for scanning
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14874 )
Change subject: memrowset: small optimizations for scanning
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14874
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia44b34606439625fbbbcc83e3652455a8894a0b3
Gerrit-Change-Number: 14874
Gerrit-PatchSet: 5
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <an...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Sat, 18 Jan 2020 00:12:48 +0000
Gerrit-HasComments: No
[kudu-CR] memrowset: small optimizations for scanning
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14874 )
Change subject: memrowset: small optimizations for scanning
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14874/2/src/kudu/tablet/cbtree-test.cc
File src/kudu/tablet/cbtree-test.cc:
http://gerrit.cloudera.org:8080/#/c/14874/2/src/kudu/tablet/cbtree-test.cc@45
PS2, Line 45: using std::unique_ptr;
nit: flip order
--
To view, visit http://gerrit.cloudera.org:8080/14874
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia44b34606439625fbbbcc83e3652455a8894a0b3
Gerrit-Change-Number: 14874
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <an...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 16 Jan 2020 21:52:51 +0000
Gerrit-HasComments: Yes
[kudu-CR] memrowset: small optimizations for scanning
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/14874 )
Change subject: memrowset: small optimizations for scanning
......................................................................
Patch Set 4:
(1 comment)
fixed nit and rebased to master
http://gerrit.cloudera.org:8080/#/c/14874/2/src/kudu/tablet/cbtree-test.cc
File src/kudu/tablet/cbtree-test.cc:
http://gerrit.cloudera.org:8080/#/c/14874/2/src/kudu/tablet/cbtree-test.cc@45
PS2, Line 45: using std::unordered_s
> nit: flip order
Done
--
To view, visit http://gerrit.cloudera.org:8080/14874
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia44b34606439625fbbbcc83e3652455a8894a0b3
Gerrit-Change-Number: 14874
Gerrit-PatchSet: 4
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <an...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 17 Jan 2020 21:08:02 +0000
Gerrit-HasComments: Yes