You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hive.apache.org by "Miklos Gergely (JIRA)" <ji...@apache.org> on 2018/05/28 17:03:00 UTC

[jira] [Comment Edited] (HIVE-19711) Refactor Hive Schema Tool

    [ https://issues.apache.org/jira/browse/HIVE-19711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16492817#comment-16492817 ] 

Miklos Gergely edited comment on HIVE-19711 at 5/28/18 5:02 PM:
----------------------------------------------------------------

[~alangates] let that be a second step, for now I suggest to merge this in, and see that is working fine. Later we can find the way to merge those two programs together. 

UPDATE: I've checked it, and MetastoreSchemaTool is only used in the tests! So it should be under src/test, not under src/main. Obviously HiveSchemaTool can't extend a class that is for testing only, it should be the other way around.

cc [~ashutoshc]


was (Author: mgergely):
[~alangates] let that be a second step, for now I suggest to merge this in, and see that is working fine. Later we can find the way to merge those two programs together.

cc [~ashutoshc]

> Refactor Hive Schema Tool
> -------------------------
>
>                 Key: HIVE-19711
>                 URL: https://issues.apache.org/jira/browse/HIVE-19711
>             Project: Hive
>          Issue Type: Bug
>          Components: Hive
>    Affects Versions: 3.0.0
>            Reporter: Miklos Gergely
>            Assignee: Miklos Gergely
>            Priority: Minor
>             Fix For: 4.0.0
>
>         Attachments: HIVE-19711.01.patch
>
>
> HiveSchemaTool is an 1500 lines long class trying to do everything It shold be cut into multiple classes doing smaller components.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)