[GitHub] [kafka-site] divijvaidya commented on a diff in pull request #421: KAFKA-13868: Add ASF links to the footer including privacy policy

[GitBox <gi...@apache.org>]

divijvaidya commented on code in PR #421:
URL: https://github.com/apache/kafka-site/pull/421#discussion_r923583008


##########
includes/_top.htm:
##########
@@ -150,6 +150,48 @@
 							</li>
 						</ul>
 					</li>
+					<li class="top-nav-item" role="menuitem">
+						<a href="#" class="top-nav-item-anchor" aria-haspopup="true" aria-expanded="false" aria-controls="nav-community-menu">
+							Apache Software
+						</a>
+						<ul class="top-nav-menu" aria-hidden="true" role="menu" id="nav-community-menu" title="Apache Homepage">
+							<li class="top-nav-menu-item" role="menuitem">
+								<a class="top-nav-anchor" tabindex="-1" href="https://www.apache.org/" target="_blank">
+									Apache Homepage

Review Comment:
   I have made the changes as suggested by @tombentley and added the ASF links to the footer. Note that there are some projects which choose to keep a separate section in nav bar for ASF links (e.g. [Spark](https://spark.apache.org/), [TinkerPop](https://tinkerpop.apache.org/)) while some other choose to keep it in the footer (e.g. [superset](https://superset.apache.org/), [Hudi](https://hudi.apache.org/)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org