You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@parquet.apache.org by GitBox <gi...@apache.org> on 2021/08/11 07:57:53 UTC
[GitHub] [parquet-mr] Ted-Jiang opened a new pull request #922: [PARQUET-2073] Fix estimate remaining row count in ColumnWriteStoreBase.
Ted-Jiang opened a new pull request #922:
URL: https://github.com/apache/parquet-mr/pull/922
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Parquet Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references them in the PR title. For example, "PARQUET-1234: My Parquet PR"
- https://issues.apache.org/jira/browse/PARQUET-XXX
- In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes how to use it.
- All the public functions and the classes in the PR contain Javadoc that explain what it does
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] Ted-Jiang closed pull request #922: [PARQUET-2073] Fix estimate remaining row count in ColumnWriteStoreBase.
Posted by GitBox <gi...@apache.org>.
Ted-Jiang closed pull request #922:
URL: https://github.com/apache/parquet-mr/pull/922
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] shangxinli commented on a change in pull request #922: [PARQUET-2073] Fix estimate remaining row count in ColumnWriteStoreBase.
Posted by GitBox <gi...@apache.org>.
shangxinli commented on a change in pull request #922:
URL: https://github.com/apache/parquet-mr/pull/922#discussion_r686998127
##########
File path: parquet-column/src/main/java/org/apache/parquet/column/impl/ColumnWriteStoreBase.java
##########
@@ -237,10 +237,11 @@ private void sizeCheck() {
} else {
rowCountForNextRowCountCheck = min(rowCountForNextRowCountCheck, writer.getRowsWrittenSoFar() + pageRowCountLimit);
}
+ //estimate remaining row count by previous input for next row count check
long rowsToFillPage =
usedMem == 0 ?
props.getMaxRowCountForPageSizeCheck()
- : (long) rows / usedMem * remainingMem;
+ : rows * remainingMem / usedMem;
Review comment:
Should we worry about overflow by (rows * remainingMem)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] gszadovszky commented on a change in pull request #922: [PARQUET-2073] Fix estimate remaining row count in ColumnWriteStoreBase.
Posted by GitBox <gi...@apache.org>.
gszadovszky commented on a change in pull request #922:
URL: https://github.com/apache/parquet-mr/pull/922#discussion_r687017605
##########
File path: parquet-column/src/main/java/org/apache/parquet/column/impl/ColumnWriteStoreBase.java
##########
@@ -237,10 +237,11 @@ private void sizeCheck() {
} else {
rowCountForNextRowCountCheck = min(rowCountForNextRowCountCheck, writer.getRowsWrittenSoFar() + pageRowCountLimit);
}
+ //estimate remaining row count by previous input for next row count check
long rowsToFillPage =
usedMem == 0 ?
props.getMaxRowCountForPageSizeCheck()
- : (long) rows / usedMem * remainingMem;
+ : rows * remainingMem / usedMem;
Review comment:
I've felt it as a low risk. We are talking about pages here so the neither the row count nor the used memory should be too high that this would overflow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] gszadovszky merged pull request #922: [PARQUET-2073] Fix estimate remaining row count in ColumnWriteStoreBase.
Posted by GitBox <gi...@apache.org>.
gszadovszky merged pull request #922:
URL: https://github.com/apache/parquet-mr/pull/922
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] Ted-Jiang commented on a change in pull request #922: [PARQUET-2073] Fix estimate remaining row count in ColumnWriteStoreBase.
Posted by GitBox <gi...@apache.org>.
Ted-Jiang commented on a change in pull request #922:
URL: https://github.com/apache/parquet-mr/pull/922#discussion_r687323376
##########
File path: parquet-column/src/main/java/org/apache/parquet/column/impl/ColumnWriteStoreBase.java
##########
@@ -237,10 +237,11 @@ private void sizeCheck() {
} else {
rowCountForNextRowCountCheck = min(rowCountForNextRowCountCheck, writer.getRowsWrittenSoFar() + pageRowCountLimit);
}
+ //estimate remaining row count by previous input for next row count check
long rowsToFillPage =
usedMem == 0 ?
props.getMaxRowCountForPageSizeCheck()
- : (long) rows / usedMem * remainingMem;
+ : rows * remainingMem / usedMem;
Review comment:
Same as gszadovszky +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] gszadovszky commented on pull request #922: [PARQUET-2073] Fix estimate remaining row count in ColumnWriteStoreBase.
Posted by GitBox <gi...@apache.org>.
gszadovszky commented on pull request #922:
URL: https://github.com/apache/parquet-mr/pull/922#issuecomment-899361173
@shangxinli, I'm merging this. Let's see how it is working.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] gszadovszky commented on a change in pull request #922: [PARQUET-2073] Fix estimate remaining row count in ColumnWriteStoreBase.
Posted by GitBox <gi...@apache.org>.
gszadovszky commented on a change in pull request #922:
URL: https://github.com/apache/parquet-mr/pull/922#discussion_r687017605
##########
File path: parquet-column/src/main/java/org/apache/parquet/column/impl/ColumnWriteStoreBase.java
##########
@@ -237,10 +237,11 @@ private void sizeCheck() {
} else {
rowCountForNextRowCountCheck = min(rowCountForNextRowCountCheck, writer.getRowsWrittenSoFar() + pageRowCountLimit);
}
+ //estimate remaining row count by previous input for next row count check
long rowsToFillPage =
usedMem == 0 ?
props.getMaxRowCountForPageSizeCheck()
- : (long) rows / usedMem * remainingMem;
+ : rows * remainingMem / usedMem;
Review comment:
I've felt it as a low risk. We are talking about pages here so neither the row count nor the used memory should be too high that this would overflow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org