You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Sanjeev Neelarapu <sa...@accelerite.com> on 2016/03/29 10:59:19 UTC

Hard coded test data

Hi,

Some of the tests have hard coded test data inside tests and due to this some of the tests are failing in CI runs.
E.g:
Test_privategw_acl.py has lot of hard coded test data like vlans, static routes and private gateway configuration.  Unless we have these configured in test environment, tests would never pass.

It is good practice to move the test data to test_data.py file instead of hardcoding it.

I request the owner of this test suite file to fix it and make it more generic.

Best Regards,
Sanjeev N
Chief Product Engineer, Accelerite
Off: +91 40 6722 9368 | EMail: sanjeev.neelarapu@accelerite.com<ma...@accelerite.com>
[cid:image001.png@01D18361.DE542D60]




DISCLAIMER
==========
This e-mail may contain privileged and confidential information which is the property of Accelerite, a Persistent Systems business. It is intended only for the use of the individual or entity to which it is addressed. If you are not the intended recipient, you are not authorized to read, retain, copy, print, distribute or use this message. If you have received this communication in error, please notify the sender and delete all copies of this message. Accelerite, a Persistent Systems business does not accept any liability for virus infected mails.

Re: Hard coded test data

Posted by Koushik Das <ko...@accelerite.com>.
Please file tracking bugs for all such issues


________________________________
From: Sanjeev Neelarapu <sa...@accelerite.com>
Sent: Tuesday, March 29, 2016 2:29 PM
To: dev@cloudstack.apache.org
Subject: Hard coded test data


Hi,



Some of the tests have hard coded test data inside tests and due to this some of the tests are failing in CI runs.

E.g:

Test_privategw_acl.py has lot of hard coded test data like vlans, static routes and private gateway configuration.  Unless we have these configured in test environment, tests would never pass.



It is good practice to move the test data to test_data.py file instead of hardcoding it.



I request the owner of this test suite file to fix it and make it more generic.



Best Regards,

Sanjeev N

Chief Product Engineer, Accelerite

Off: +91 40 6722 9368 | EMail: sanjeev.neelarapu@accelerite.com<ma...@accelerite.com>

[cid:image001.png@01D18361.DE542D60]



DISCLAIMER ========== This e-mail may contain privileged and confidential information which is the property of Accelerite, a Persistent Systems business. It is intended only for the use of the individual or entity to which it is addressed. If you are not the intended recipient, you are not authorized to read, retain, copy, print, distribute or use this message. If you have received this communication in error, please notify the sender and delete all copies of this message. Accelerite, a Persistent Systems business does not accept any liability for virus infected mails.



DISCLAIMER
==========
This e-mail may contain privileged and confidential information which is the property of Accelerite, a Persistent Systems business. It is intended only for the use of the individual or entity to which it is addressed. If you are not the intended recipient, you are not authorized to read, retain, copy, print, distribute or use this message. If you have received this communication in error, please notify the sender and delete all copies of this message. Accelerite, a Persistent Systems business does not accept any liability for virus infected mails.