You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2021/11/04 14:44:55 UTC
[GitHub] [fineract] ptuomola opened a new pull request #1955: FINERACT-1428: Introduce GitHub Actions as CI
ptuomola opened a new pull request #1955:
URL: https://github.com/apache/fineract/pull/1955
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284).
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm with details of any API changes
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] BLasan commented on a change in pull request #1955: FINERACT-1428: Introduce GitHub Actions as CI
Posted by GitBox <gi...@apache.org>.
BLasan commented on a change in pull request #1955:
URL: https://github.com/apache/fineract/pull/1955#discussion_r742984091
##########
File path: .github/workflows/build-docker.yml
##########
@@ -0,0 +1,20 @@
+name: Fineract Docker build
+
+on: [push]
+
+jobs:
+ build:
+ runs-on: ubuntu-latest
Review comment:
Wouldn't it be a good idea to use ubuntu 20.04 LTS (Long Term Support version) ? I think the latest release is Ubuntu 21.10
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] BLasan commented on a change in pull request #1955: FINERACT-1428: Introduce GitHub Actions as CI
Posted by GitBox <gi...@apache.org>.
BLasan commented on a change in pull request #1955:
URL: https://github.com/apache/fineract/pull/1955#discussion_r742984091
##########
File path: .github/workflows/build-docker.yml
##########
@@ -0,0 +1,20 @@
+name: Fineract Docker build
+
+on: [push]
+
+jobs:
+ build:
+ runs-on: ubuntu-latest
Review comment:
Wouldn't it be a good idea to use ubuntu 20.04 LTS (Long Term Support version) ? I think the latest would be Ubuntu 21.10
##########
File path: .github/workflows/build-docker.yml
##########
@@ -0,0 +1,20 @@
+name: Fineract Docker build
+
+on: [push]
+
+jobs:
+ build:
+ runs-on: ubuntu-latest
Review comment:
Wouldn't it be a good idea to use ubuntu 20.04 LTS (Long Term Support version) ? I think the latest release is Ubuntu 21.10
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vidakovic commented on a change in pull request #1955: FINERACT-1428: Introduce GitHub Actions as CI
Posted by GitBox <gi...@apache.org>.
vidakovic commented on a change in pull request #1955:
URL: https://github.com/apache/fineract/pull/1955#discussion_r743402519
##########
File path: .github/workflows/sonarqube.yml
##########
@@ -0,0 +1,32 @@
+name: Fineract Sonarqube
+on: [push]
+
+jobs:
+ build:
+ runs-on: ubuntu-20.04
+ env:
+ TZ: Asia/Kolkata
+ SONAR_ORGANIZATION: apache
+ SONAR_HOST_URL: https://sonarcloud.io
+ SONAR_TOKEN: "Q2E9ijK+9+R6nkb9o2FQrKUiAozp0325mlGfM25rGV3mCRPyWR/lU8o48r2eaBEX8SEvMvXIO3XXD9SPyUX2+svLz0MOMdfZfNveg6jmcHNRjkzzBK0bMIIGbEH/YqJ+psl4nDmlDd6IK4685/1JSRUJLqeKKK2ulixm6PXcmwZWeKD6TjyXsW50zz3yYIOuROHzys/M6H05h1dZD3j6ztnRsjbr7SmqFEVWSRgEd/aAs+HZB9Fv1xN66csRoQUQKgzoBO9egAQcel65Av0Bf+pOQuzVDVyXNohZEYia02MCGlC6OFvtL7xIXGf/vo02RdnlN4Jnma6P37TaNrmpk2e+EGJaZHmL9cb98+Zc39uPb7qEZkMfDdKrW6QVRtScSuCJzpY58WRgTS0jLCxsDBAMfsrIvWbHntFZL9q5aEkFgecj0pg9u6WHxgA8cuPUY5QzHQo9fEUxNJHGJHQ2FkafLniqJp7DVbsyQHmEggaTrGGrketeYvCbSR1oOnBgImUwzjIV9/zOdd10Wzi8x9HsmzrGBPSBaO4fBxjC1LZwdyue2a2+oKvBqpAGcLpGaCRfHTh2yPXhZW4bw11rOmQxgtOQVBXhveciWAUQuVXIak+RZnu/zRvnul9sZ6bb1hEUPkpUypk+FDeLm8T7y2A++u/jBam2vLc0iff5xtA="
Review comment:
@ptuomola should we move this to Github's settings -> security -> secrets? I tried to access that page on Github... but have not enough privileges... probably that's why you put it here... just as a note.
##########
File path: .github/workflows/sonarqube.yml
##########
@@ -0,0 +1,32 @@
+name: Fineract Sonarqube
+on: [push]
+
+jobs:
+ build:
+ runs-on: ubuntu-20.04
+ env:
+ TZ: Asia/Kolkata
+ SONAR_ORGANIZATION: apache
+ SONAR_HOST_URL: https://sonarcloud.io
+ SONAR_TOKEN: "Q2E9ijK+9+R6nkb9o2FQrKUiAozp0325mlGfM25rGV3mCRPyWR/lU8o48r2eaBEX8SEvMvXIO3XXD9SPyUX2+svLz0MOMdfZfNveg6jmcHNRjkzzBK0bMIIGbEH/YqJ+psl4nDmlDd6IK4685/1JSRUJLqeKKK2ulixm6PXcmwZWeKD6TjyXsW50zz3yYIOuROHzys/M6H05h1dZD3j6ztnRsjbr7SmqFEVWSRgEd/aAs+HZB9Fv1xN66csRoQUQKgzoBO9egAQcel65Av0Bf+pOQuzVDVyXNohZEYia02MCGlC6OFvtL7xIXGf/vo02RdnlN4Jnma6P37TaNrmpk2e+EGJaZHmL9cb98+Zc39uPb7qEZkMfDdKrW6QVRtScSuCJzpY58WRgTS0jLCxsDBAMfsrIvWbHntFZL9q5aEkFgecj0pg9u6WHxgA8cuPUY5QzHQo9fEUxNJHGJHQ2FkafLniqJp7DVbsyQHmEggaTrGGrketeYvCbSR1oOnBgImUwzjIV9/zOdd10Wzi8x9HsmzrGBPSBaO4fBxjC1LZwdyue2a2+oKvBqpAGcLpGaCRfHTh2yPXhZW4bw11rOmQxgtOQVBXhveciWAUQuVXIak+RZnu/zRvnul9sZ6bb1hEUPkpUypk+FDeLm8T7y2A++u/jBam2vLc0iff5xtA="
Review comment:
@ptuomola should we move this to Github's settings -> security -> secrets? I tried to access that page on Github... but have not enough privileges... probably that's why you put it here... just as a note.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] awasum commented on a change in pull request #1955: FINERACT-1428: Introduce GitHub Actions as CI
Posted by GitBox <gi...@apache.org>.
awasum commented on a change in pull request #1955:
URL: https://github.com/apache/fineract/pull/1955#discussion_r743186530
##########
File path: .github/workflows/build-docker.yml
##########
@@ -0,0 +1,20 @@
+name: Fineract Docker build
+
+on: [push]
+
+jobs:
+ build:
+ runs-on: ubuntu-latest
Review comment:
Lets use Latest LTS version say Ubuntu 20.04 here..Minor..but makes sense. See: https://cloudmaniac.net/docker-container-never-use-latest-cicd-pipeline/
##########
File path: .github/workflows/build.yml
##########
@@ -0,0 +1,38 @@
+name: Fineract Gradle build
+on: [push]
+
+jobs:
+ build:
+ runs-on: ubuntu-latest
+ env:
+ TZ: Asia/Kolkata
Review comment:
@ptuomola already answered this here and it makes sense. Thanks...so resolving this. see: https://github.com/apache/fineract/pull/1955#issuecomment-961172334
##########
File path: .github/workflows/sonarqube.yml
##########
@@ -0,0 +1,32 @@
+name: Fineract Sonarqube
+on: [push]
+
+jobs:
+ build:
+ runs-on: ubuntu-latest
Review comment:
Just minor: See above: https://github.com/apache/fineract/pull/1955/files#r743186530
##########
File path: .github/workflows/build-docker.yml
##########
@@ -0,0 +1,20 @@
+name: Fineract Docker build
+
+on: [push]
+
+jobs:
+ build:
+ runs-on: ubuntu-latest
Review comment:
Lets use Latest LTS version say Ubuntu 20.04 here..Minor..but makes sense. See: https://cloudmaniac.net/docker-container-never-use-latest-cicd-pipeline/
##########
File path: .github/workflows/build.yml
##########
@@ -0,0 +1,38 @@
+name: Fineract Gradle build
+on: [push]
+
+jobs:
+ build:
+ runs-on: ubuntu-latest
+ env:
+ TZ: Asia/Kolkata
Review comment:
@ptuomola already answered this here and it makes sense. Thanks...so resolving this. see: https://github.com/apache/fineract/pull/1955#issuecomment-961172334
##########
File path: .github/workflows/sonarqube.yml
##########
@@ -0,0 +1,32 @@
+name: Fineract Sonarqube
+on: [push]
+
+jobs:
+ build:
+ runs-on: ubuntu-latest
Review comment:
Just minor: See above: https://github.com/apache/fineract/pull/1955/files#r743186530
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola commented on pull request #1955: FINERACT-1428: Introduce GitHub Actions as CI
Posted by GitBox <gi...@apache.org>.
ptuomola commented on pull request #1955:
URL: https://github.com/apache/fineract/pull/1955#issuecomment-961618550
Self-merging based on feedback from @awasum after agreed fixes. Most likely this will need some further changes but we can only test once these workflows are part of the repo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola merged pull request #1955: FINERACT-1428: Introduce GitHub Actions as CI
Posted by GitBox <gi...@apache.org>.
ptuomola merged pull request #1955:
URL: https://github.com/apache/fineract/pull/1955
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola commented on pull request #1955: FINERACT-1428: Introduce GitHub Actions as CI
Posted by GitBox <gi...@apache.org>.
ptuomola commented on pull request #1955:
URL: https://github.com/apache/fineract/pull/1955#issuecomment-961618550
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] awasum commented on a change in pull request #1955: FINERACT-1428: Introduce GitHub Actions as CI
Posted by GitBox <gi...@apache.org>.
awasum commented on a change in pull request #1955:
URL: https://github.com/apache/fineract/pull/1955#discussion_r743188767
##########
File path: .github/workflows/sonarqube.yml
##########
@@ -0,0 +1,32 @@
+name: Fineract Sonarqube
+on: [push]
+
+jobs:
+ build:
+ runs-on: ubuntu-latest
Review comment:
Just minor: See above: https://github.com/apache/fineract/pull/1955/files#r743186530
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola commented on pull request #1955: FINERACT-1428: Introduce GitHub Actions as CI
Posted by GitBox <gi...@apache.org>.
ptuomola commented on pull request #1955:
URL: https://github.com/apache/fineract/pull/1955#issuecomment-961172334
Yes.
Ideally Fineract would respect the tenant tile zones configured in the
database, and then the server time zone would not matter.
However this is not working 100%. Consequently a number of the integration
tests fail intermittently if the server time zone is not the same as the
tenant time zone.
As our integration tests use tenant time zone as Asia/Kolkata, we need to
set the server timezone to be the same to avoid "flakiness" of tests
If you look in the Travis CI script you can see the same setting hardcoded
there.
On Thu, Nov 4, 2021, 23:11 Benura Abeywardena ***@***.***>
wrote:
> ***@***.**** commented on this pull request.
> ------------------------------
>
> In .github/workflows/build.yml
> <https://github.com/apache/fineract/pull/1955#discussion_r742933283>:
>
> > @@ -0,0 +1,38 @@
> +name: Fineract Gradle build
> +on: [push]
> +
> +jobs:
> + build:
> + runs-on: ubuntu-latest
> + env:
> + TZ: Asia/Kolkata
>
> Any specific reason to select TZ as Asia/Kolkata ?
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/fineract/pull/1955#pullrequestreview-797876295>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AASJVCXQYUBG2AVA3X6HE4TUKKPDPANCNFSM5HLTWCBA>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vidakovic commented on a change in pull request #1955: FINERACT-1428: Introduce GitHub Actions as CI
Posted by GitBox <gi...@apache.org>.
vidakovic commented on a change in pull request #1955:
URL: https://github.com/apache/fineract/pull/1955#discussion_r743402519
##########
File path: .github/workflows/sonarqube.yml
##########
@@ -0,0 +1,32 @@
+name: Fineract Sonarqube
+on: [push]
+
+jobs:
+ build:
+ runs-on: ubuntu-20.04
+ env:
+ TZ: Asia/Kolkata
+ SONAR_ORGANIZATION: apache
+ SONAR_HOST_URL: https://sonarcloud.io
+ SONAR_TOKEN: "Q2E9ijK+9+R6nkb9o2FQrKUiAozp0325mlGfM25rGV3mCRPyWR/lU8o48r2eaBEX8SEvMvXIO3XXD9SPyUX2+svLz0MOMdfZfNveg6jmcHNRjkzzBK0bMIIGbEH/YqJ+psl4nDmlDd6IK4685/1JSRUJLqeKKK2ulixm6PXcmwZWeKD6TjyXsW50zz3yYIOuROHzys/M6H05h1dZD3j6ztnRsjbr7SmqFEVWSRgEd/aAs+HZB9Fv1xN66csRoQUQKgzoBO9egAQcel65Av0Bf+pOQuzVDVyXNohZEYia02MCGlC6OFvtL7xIXGf/vo02RdnlN4Jnma6P37TaNrmpk2e+EGJaZHmL9cb98+Zc39uPb7qEZkMfDdKrW6QVRtScSuCJzpY58WRgTS0jLCxsDBAMfsrIvWbHntFZL9q5aEkFgecj0pg9u6WHxgA8cuPUY5QzHQo9fEUxNJHGJHQ2FkafLniqJp7DVbsyQHmEggaTrGGrketeYvCbSR1oOnBgImUwzjIV9/zOdd10Wzi8x9HsmzrGBPSBaO4fBxjC1LZwdyue2a2+oKvBqpAGcLpGaCRfHTh2yPXhZW4bw11rOmQxgtOQVBXhveciWAUQuVXIak+RZnu/zRvnul9sZ6bb1hEUPkpUypk+FDeLm8T7y2A++u/jBam2vLc0iff5xtA="
Review comment:
@ptuomola should we move this to Github's settings -> security -> secrets? I tried to access that page on Github... but have not enough privileges... probably that's why you put it here... just as a note.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] BLasan commented on pull request #1955: FINERACT-1428: Introduce GitHub Actions as CI
Posted by GitBox <gi...@apache.org>.
BLasan commented on pull request #1955:
URL: https://github.com/apache/fineract/pull/1955#issuecomment-961187492
> Yes. Ideally Fineract would respect the tenant tile zones configured in the database, and then the server time zone would not matter. However this is not working 100%. Consequently a number of the integration tests fail intermittently if the server time zone is not the same as the tenant time zone. As our integration tests use tenant time zone as Asia/Kolkata, we need to set the server timezone to be the same to avoid "flakiness" of tests If you look in the Travis CI script you can see the same setting hardcoded there.
> […](#)
> On Thu, Nov 4, 2021, 23:11 Benura Abeywardena ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In .github/workflows/build.yml <[#1955 (comment)](https://github.com/apache/fineract/pull/1955#discussion_r742933283)>: > @@ -0,0 +1,38 @@ +name: Fineract Gradle build +on: [push] + +jobs: + build: + runs-on: ubuntu-latest + env: + TZ: Asia/Kolkata Any specific reason to select TZ as Asia/Kolkata ? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <[#1955 (review)](https://github.com/apache/fineract/pull/1955#pullrequestreview-797876295)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AASJVCXQYUBG2AVA3X6HE4TUKKPDPANCNFSM5HLTWCBA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=
utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
Thanks !!! Looks good to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] BLasan commented on a change in pull request #1955: FINERACT-1428: Introduce GitHub Actions as CI
Posted by GitBox <gi...@apache.org>.
BLasan commented on a change in pull request #1955:
URL: https://github.com/apache/fineract/pull/1955#discussion_r742984091
##########
File path: .github/workflows/build-docker.yml
##########
@@ -0,0 +1,20 @@
+name: Fineract Docker build
+
+on: [push]
+
+jobs:
+ build:
+ runs-on: ubuntu-latest
Review comment:
Wouldn't it a good idea to use ubuntu 20.04 LTS (Long Term Support version) ? I think the latest would be Ubuntu 21.10
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola merged pull request #1955: FINERACT-1428: Introduce GitHub Actions as CI
Posted by GitBox <gi...@apache.org>.
ptuomola merged pull request #1955:
URL: https://github.com/apache/fineract/pull/1955
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] awasum commented on a change in pull request #1955: FINERACT-1428: Introduce GitHub Actions as CI
Posted by GitBox <gi...@apache.org>.
awasum commented on a change in pull request #1955:
URL: https://github.com/apache/fineract/pull/1955#discussion_r743188229
##########
File path: .github/workflows/build.yml
##########
@@ -0,0 +1,38 @@
+name: Fineract Gradle build
+on: [push]
+
+jobs:
+ build:
+ runs-on: ubuntu-latest
+ env:
+ TZ: Asia/Kolkata
Review comment:
@ptuomola already answered this here and it makes sense. Thanks...so resolving this. see: https://github.com/apache/fineract/pull/1955#issuecomment-961172334
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola merged pull request #1955: FINERACT-1428: Introduce GitHub Actions as CI
Posted by GitBox <gi...@apache.org>.
ptuomola merged pull request #1955:
URL: https://github.com/apache/fineract/pull/1955
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] BLasan commented on a change in pull request #1955: FINERACT-1428: Introduce GitHub Actions as CI
Posted by GitBox <gi...@apache.org>.
BLasan commented on a change in pull request #1955:
URL: https://github.com/apache/fineract/pull/1955#discussion_r742933283
##########
File path: .github/workflows/build.yml
##########
@@ -0,0 +1,38 @@
+name: Fineract Gradle build
+on: [push]
+
+jobs:
+ build:
+ runs-on: ubuntu-latest
+ env:
+ TZ: Asia/Kolkata
Review comment:
Any specific reason to select TZ as Asia/Kolkata ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] awasum commented on a change in pull request #1955: FINERACT-1428: Introduce GitHub Actions as CI
Posted by GitBox <gi...@apache.org>.
awasum commented on a change in pull request #1955:
URL: https://github.com/apache/fineract/pull/1955#discussion_r743186530
##########
File path: .github/workflows/build-docker.yml
##########
@@ -0,0 +1,20 @@
+name: Fineract Docker build
+
+on: [push]
+
+jobs:
+ build:
+ runs-on: ubuntu-latest
Review comment:
Lets use Latest LTS version say Ubuntu 20.04 here..Minor..but makes sense. See: https://cloudmaniac.net/docker-container-never-use-latest-cicd-pipeline/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola commented on pull request #1955: FINERACT-1428: Introduce GitHub Actions as CI
Posted by GitBox <gi...@apache.org>.
ptuomola commented on pull request #1955:
URL: https://github.com/apache/fineract/pull/1955#issuecomment-961648176
Yes spot on - that’s actually the problem I have not yet managed to resolve
with this migration to GitHub Actions.
That token is actually already encrypted. Travis has a feature to decrypt
it before using, hence it’s safe to add it there.
But Github does not have such feature, hence Sonarqube as git action is
currently failing as it can’t use the encrypted token.
The three options that I can see to implement the same on GitHub are:
1. Use Github secrets. But my understanding is that that’s not allowed for
Apache repos
2. Use Sonarqubes GitHub app. Again, not allowed as far as I know
3. Put the token as plaintext. Insecure, so really not a good plan.
So I think for now I’ll focus on trying to get the build to run in GitHub
Actions. We can leave Sonarqube on Travis for now, until someone comes up
with a good idea on how to solve this.
On Fri, 5 Nov 2021 at 1:46 PM, Aleksandar Vidakovic <
***@***.***> wrote:
> ***@***.**** commented on this pull request.
> ------------------------------
>
> In .github/workflows/sonarqube.yml
> <https://github.com/apache/fineract/pull/1955#discussion_r743402519>:
>
> > @@ -0,0 +1,32 @@
> +name: Fineract Sonarqube
> +on: [push]
> +
> +jobs:
> + build:
> + runs-on: ubuntu-20.04
> + env:
> + TZ: Asia/Kolkata
> + SONAR_ORGANIZATION: apache
> + SONAR_HOST_URL: https://sonarcloud.io
> + SONAR_TOKEN: "Q2E9ijK+9+R6nkb9o2FQrKUiAozp0325mlGfM25rGV3mCRPyWR/lU8o48r2eaBEX8SEvMvXIO3XXD9SPyUX2+svLz0MOMdfZfNveg6jmcHNRjkzzBK0bMIIGbEH/YqJ+psl4nDmlDd6IK4685/1JSRUJLqeKKK2ulixm6PXcmwZWeKD6TjyXsW50zz3yYIOuROHzys/M6H05h1dZD3j6ztnRsjbr7SmqFEVWSRgEd/aAs+HZB9Fv1xN66csRoQUQKgzoBO9egAQcel65Av0Bf+pOQuzVDVyXNohZEYia02MCGlC6OFvtL7xIXGf/vo02RdnlN4Jnma6P37TaNrmpk2e+EGJaZHmL9cb98+Zc39uPb7qEZkMfDdKrW6QVRtScSuCJzpY58WRgTS0jLCxsDBAMfsrIvWbHntFZL9q5aEkFgecj0pg9u6WHxgA8cuPUY5QzHQo9fEUxNJHGJHQ2FkafLniqJp7DVbsyQHmEggaTrGGrketeYvCbSR1oOnBgImUwzjIV9/zOdd10Wzi8x9HsmzrGBPSBaO4fBxjC1LZwdyue2a2+oKvBqpAGcLpGaCRfHTh2yPXhZW4bw11rOmQxgtOQVBXhveciWAUQuVXIak+RZnu/zRvnul9sZ6bb1hEUPkpUypk+FDeLm8T7y2A++u/jBam2vLc0iff5xtA="
>
> @ptuomola <https://github.com/ptuomola> should we move this to Github's
> settings -> security -> secrets? I tried to access that page on Github...
> but have not enough privileges... probably that's why you put it here...
> just as a note.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/fineract/pull/1955#pullrequestreview-798513583>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AASJVCVEQAODNBMZ2GESDD3UKNVTDANCNFSM5HLTWCBA>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org