You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "Wes McKinney (Jira)" <ji...@apache.org> on 2019/09/20 00:54:00 UTC
[jira] [Closed] (ARROW-5036) [Plasma][C++] Serialization tests
resort to memcpy to check equality
[ https://issues.apache.org/jira/browse/ARROW-5036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Wes McKinney closed ARROW-5036.
-------------------------------
> [Plasma][C++] Serialization tests resort to memcpy to check equality
> --------------------------------------------------------------------
>
> Key: ARROW-5036
> URL: https://issues.apache.org/jira/browse/ARROW-5036
> Project: Apache Arrow
> Issue Type: Bug
> Components: C++ - Plasma
> Reporter: Francois Saint-Jacques
> Priority: Major
>
> {code:bash}
> 1: /tmp/arrow-0.13.0.Q4czW/apache-arrow-0.13.0/cpp/src/plasma/test/serialization_tests.cc:193: Failure
> 1: Expected equality of these values:
> 1: memcmp(&plasma_objects[object_ids[0]], &plasma_objects_return[0], sizeof(PlasmaObject))
> 1: Which is: 45
> 1: 0
> 1: [ FAILED ] PlasmaSerialization.GetReply (0 ms)
> {code}
> The source of the problem is the random_plasma_object stack allocated object. As a fix, I propose that PlasmaObject implements the `operator==` method and drops the memcpy equality check.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)