You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2012/12/11 22:14:34 UTC
Re: Review Request: Fix for doing executor setup inside the forked process
in cgroups isolation module
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8096/#review14313
-----------------------------------------------------------
Ship it!
src/slave/cgroups_isolation_module.cpp
<https://reviews.apache.org/r/8096/#comment30473>
Thanks!
- Benjamin Hindman
On Nov. 19, 2012, 3:49 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8096/
> -----------------------------------------------------------
>
> (Updated Nov. 19, 2012, 3:49 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Description
> -------
>
> Now, we do the executor setup (fetching etc) inside the forked process but before assigning the process to its own cgroup.
>
> This accomplishes two things:
> --> unblocks the cgroups isolation module from any potential hangs during executor setup
> --> does not charge (for memory) the executor for the setup
>
>
> This addresses bug MESOS-310.
> https://issues.apache.org/jira/browse/MESOS-310
>
>
> Diffs
> -----
>
> src/slave/cgroups_isolation_module.cpp 8211618d7729350654e2d17946c5b912ed9dda6a
> src/slave/process_based_isolation_module.cpp 16fd584e78db2c517d828f2576ab8a38c5ce57ad
>
> Diff: https://reviews.apache.org/r/8096/diff/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Vinod Kone
>
>