[GitHub] spark pull request #11746: [SPARK-13602][CORE] Add shutdown hook to DriverRu...

[cloud-fan <gi...@git.apache.org>]

Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11746#discussion_r118542465
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/worker/DriverRunner.scala ---
    @@ -53,9 +53,11 @@ private[deploy] class DriverRunner(
       @volatile private var killed = false
     
       // Populated once finished
    -  private[worker] var finalState: Option[DriverState] = None
    -  private[worker] var finalException: Option[Exception] = None
    -  private var finalExitCode: Option[Int] = None
    +  @volatile private[worker] var finalState: Option[DriverState] = None
    +  @volatile private[worker] var finalException: Option[Exception] = None
    +
    +  // Timeout to wait for when trying to terminate a driver.
    +  private val DRIVER_TERMINATE_TIMEOUT_MS = 10 * 1000
    --- End diff --
    
    I think we should make this configurable for each application.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org