You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by prabhjyotsingh <gi...@git.apache.org> on 2015/08/26 11:42:32 UTC
[GitHub] incubator-zeppelin pull request: auto save on page navigation
GitHub user prabhjyotsingh opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/260
auto save on page navigation
This should take care of accidental browser close actions.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/prabhjyotsingh/incubator-zeppelin ZEPPELIN-265
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/260.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #260
----
commit e205428f7b69a46b48069fe4c2ce955c820b983e
Author: Prabhjyot Singh <pr...@gmail.com>
Date: 2015-08-26T09:41:00Z
auto save on page navigation
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: auto save on page navigation
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/260#issuecomment-138998239
@Leemoonsoo have resolved conflicts. Thanks for the review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: auto save on page navigation
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/260#issuecomment-139722045
@corneadoug @Leemoonsoo does this fix looks good ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: auto save on page navigation
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/260#issuecomment-135293439
This is working well.
While testing this branch I found those, and I think it could be taken care of here:
* When we fast click on notebook loading to home or fast refresh on notebook loading, we get a la few undefined errors in the console (values need to be checked before being used)
* When the timeout of startSaveTimer run after we changed page, we get an undefined error too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: auto save on page navigation
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/260#issuecomment-142972991
@corneadoug @Leemoonsoo do i need to add something as well, or is there a case that has been missed out ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: auto save on page navigation
Posted by prabhjyotsingh <gi...@git.apache.org>.
GitHub user prabhjyotsingh reopened a pull request:
https://github.com/apache/incubator-zeppelin/pull/260
auto save on page navigation
This should take care of accidental browser close actions.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/prabhjyotsingh/incubator-zeppelin ZEPPELIN-265
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/260.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #260
----
commit f78eb5f3d311e9e55cb4dd2a32b6c91f25f0657e
Author: Prabhjyot Singh <pr...@gmail.com>
Date: 2015-08-26T09:41:00Z
auto save on page navigation
commit 7f73dfb861fe8751d0b1932df1204a327aaebdb1
Author: Prabhjyot Singh <pr...@gmail.com>
Date: 2015-08-26T12:30:05Z
minor fix
commit c7fea4ef27df2e7cae34ef74a5742761a2cacebd
Author: Prabhjyot Singh <pr...@gmail.com>
Date: 2015-08-27T07:33:16Z
bug fix for "undefined errors" when page is refreshed
commit e09a84065050ce9cf8f2b7393ef0ee11883cc612
Author: Prabhjyot Singh <pr...@gmail.com>
Date: 2015-08-27T08:32:46Z
Revert "bug fix for "undefined errors" when page is refreshed"
This reverts commit 4e3ad0b304ba8c18ad085c9fe2a142fc74916d3b.
commit 0d419cfa9c1d93d2eb41b90315cb48f84e216e91
Author: Prabhjyot Singh <pr...@gmail.com>
Date: 2015-08-27T08:32:49Z
Revert "minor fix"
This reverts commit 987d196ffcc25bce40300ed415437fef1b224bc0.
commit 5719a3b8cf3f80ced04b72e8d632ed4658c601cd
Author: Prabhjyot Singh <pr...@gmail.com>
Date: 2015-08-27T08:32:57Z
Revert "auto save on page navigation"
This reverts commit e205428f7b69a46b48069fe4c2ce955c820b983e.
commit 2f4ef745528cbfb2b8ef865bee62030e50c28f95
Author: Prabhjyot Singh <pr...@gmail.com>
Date: 2015-08-27T08:35:22Z
checking state of notes and paragraphs before saving it by $scope.saveNote()
commit 28b08e0e0c23ffdf0a3a4b8a1910b398a73544c4
Author: Prabhjyot Singh <pr...@gmail.com>
Date: 2015-09-01T07:56:32Z
use of var instead of $scope;
commit 745391a87d09ac656ce4c1ff3b1d3ff3eb65ceaf
Author: Prabhjyot Singh <pr...@gmail.com>
Date: 2015-09-09T17:24:18Z
removing killSaveTimer from test case, since this is removed from the scope.
commit 768c41119f23f2944d5bc7214771c262442688e8
Author: Prabhjyot Singh <pr...@gmail.com>
Date: 2015-09-11T11:11:57Z
ZEPPELIN-265 resolving merge and build issue
commit 2971ae22c0f583971c918d480a9de7dd107bd23c
Author: Prabhjyot Singh <pr...@gmail.com>
Date: 2015-09-28T11:04:19Z
ZEPPELIN-265 squashed fix for killSaveTimer
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: auto save on page navigation
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/260
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: auto save on page navigation
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/260#issuecomment-138945440
@prabhjyotsingh @corneadoug Is it ready to merge?
Can you solve conflicts with master branch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: auto save on page navigation
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/260#issuecomment-144019074
closing this, will resolve travis build issue, and then re-open
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: auto save on page navigation
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/260#issuecomment-143977244
You can try to close/reopen the PR to relaunch the CI
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: auto save on page navigation
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/260
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: auto save on page navigation
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/260#issuecomment-143105625
@prabhjyotsingh Sorry, kinda forgot about this PR being ready.
I see that one test was squashed also what it was testing still exist, could you fix that? ``it('should first call killSaveTimer() when calling startSaveTimer()'``
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: auto save on page navigation
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/260#issuecomment-143947382
I see all builds "SUCCESS". So, does this mean this is a false positive error ?
https://s3.amazonaws.com/archive.travis-ci.org/jobs/82533319/log.txt
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: auto save on page navigation
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/260#issuecomment-135321762
@corneadoug thanks for the quick feedback.
This should take care of those error.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: auto save on page navigation
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/260#issuecomment-135334129
I was more thinking about handling it in the saveNote function directly
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: auto save on page navigation
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/260#issuecomment-143714241
@corneadoug I thought to fix that with ZEPPELIN-294 (/pull/292). Have made the relevant changes here for the review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: auto save on page navigation
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/260#issuecomment-136586108
have revert old changes, and made fix on $scope.saveNote
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---