You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@geode.apache.org by Darrel Schneider <ds...@pivotal.io> on 2016/05/17 00:01:48 UTC

Review Request 47433: handle NOT_AVAILABLE in callers of getRawOldValue

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47433/
-----------------------------------------------------------

Review request for geode, Eric Shu, Scott Jewell, Ken Howe, and Sai Boorlagadda.


Bugs: GEODE-1401
    https://issues.apache.org/jira/browse/GEODE-1401


Repository: geode


Description
-------

handle NOT_AVAILABLE in callers of getRawOldValue


Diffs
-----

  geode-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketRegionQueue.java 0243cde3c73190ddb51f956a3c57562d3738d9b0 
  geode-core/src/main/java/com/gemstone/gemfire/internal/cache/EntryEventImpl.java e241622bbfb95d2a249eae31f5ca43007476e0bb 
  geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteDestroyMessage.java bb97d9c4f6ee63761557743aa10a65cb544d2596 

Diff: https://reviews.apache.org/r/47433/diff/


Testing
-------

precheckin


Thanks,

Darrel Schneider

Re: Review Request 47433: handle NOT_AVAILABLE in callers of getRawOldValue

Posted by Sai Boorlagadda <sb...@pivotal.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47433/#review133566
-----------------------------------------------------------


Ship it!




Ship It!

- Sai Boorlagadda


On May 17, 2016, 12:01 a.m., Darrel Schneider wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47433/
> -----------------------------------------------------------
> 
> (Updated May 17, 2016, 12:01 a.m.)
> 
> 
> Review request for geode, Eric Shu, Scott Jewell, Ken Howe, and Sai Boorlagadda.
> 
> 
> Bugs: GEODE-1401
>     https://issues.apache.org/jira/browse/GEODE-1401
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> handle NOT_AVAILABLE in callers of getRawOldValue
> 
> 
> Diffs
> -----
> 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketRegionQueue.java 0243cde3c73190ddb51f956a3c57562d3738d9b0 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/cache/EntryEventImpl.java e241622bbfb95d2a249eae31f5ca43007476e0bb 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteDestroyMessage.java bb97d9c4f6ee63761557743aa10a65cb544d2596 
> 
> Diff: https://reviews.apache.org/r/47433/diff/
> 
> 
> Testing
> -------
> 
> precheckin
> 
> 
> Thanks,
> 
> Darrel Schneider
> 
>

Re: Review Request 47433: handle NOT_AVAILABLE in callers of getRawOldValue

Posted by Ken Howe <kh...@pivotal.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47433/#review133577
-----------------------------------------------------------


Ship it!




Yes, it's a simple change, but EntryEventImpl doesn't currently have much in the way of unit tests. It would be good to start beefing up the coverage when we touch the class.

- Ken Howe


On May 17, 2016, 12:01 a.m., Darrel Schneider wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47433/
> -----------------------------------------------------------
> 
> (Updated May 17, 2016, 12:01 a.m.)
> 
> 
> Review request for geode, Eric Shu, Scott Jewell, Ken Howe, and Sai Boorlagadda.
> 
> 
> Bugs: GEODE-1401
>     https://issues.apache.org/jira/browse/GEODE-1401
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> handle NOT_AVAILABLE in callers of getRawOldValue
> 
> 
> Diffs
> -----
> 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketRegionQueue.java 0243cde3c73190ddb51f956a3c57562d3738d9b0 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/cache/EntryEventImpl.java e241622bbfb95d2a249eae31f5ca43007476e0bb 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteDestroyMessage.java bb97d9c4f6ee63761557743aa10a65cb544d2596 
> 
> Diff: https://reviews.apache.org/r/47433/diff/
> 
> 
> Testing
> -------
> 
> precheckin
> 
> 
> Thanks,
> 
> Darrel Schneider
> 
>

Re: Review Request 47433: handle NOT_AVAILABLE in callers of getRawOldValue

Posted by Darrel Schneider <ds...@pivotal.io>.


> On May 17, 2016, 10:03 a.m., Ken Howe wrote:
> > Can we add a unit tests for this?

I unit test could be added. I didn't think it was needed since it was a simple change.


- Darrel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47433/#review133570
-----------------------------------------------------------


On May 16, 2016, 5:01 p.m., Darrel Schneider wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47433/
> -----------------------------------------------------------
> 
> (Updated May 16, 2016, 5:01 p.m.)
> 
> 
> Review request for geode, Eric Shu, Scott Jewell, Ken Howe, and Sai Boorlagadda.
> 
> 
> Bugs: GEODE-1401
>     https://issues.apache.org/jira/browse/GEODE-1401
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> handle NOT_AVAILABLE in callers of getRawOldValue
> 
> 
> Diffs
> -----
> 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketRegionQueue.java 0243cde3c73190ddb51f956a3c57562d3738d9b0 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/cache/EntryEventImpl.java e241622bbfb95d2a249eae31f5ca43007476e0bb 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteDestroyMessage.java bb97d9c4f6ee63761557743aa10a65cb544d2596 
> 
> Diff: https://reviews.apache.org/r/47433/diff/
> 
> 
> Testing
> -------
> 
> precheckin
> 
> 
> Thanks,
> 
> Darrel Schneider
> 
>

Re: Review Request 47433: handle NOT_AVAILABLE in callers of getRawOldValue

Posted by Ken Howe <kh...@pivotal.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47433/#review133570
-----------------------------------------------------------



Can we add a unit tests for this?

- Ken Howe


On May 17, 2016, 12:01 a.m., Darrel Schneider wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47433/
> -----------------------------------------------------------
> 
> (Updated May 17, 2016, 12:01 a.m.)
> 
> 
> Review request for geode, Eric Shu, Scott Jewell, Ken Howe, and Sai Boorlagadda.
> 
> 
> Bugs: GEODE-1401
>     https://issues.apache.org/jira/browse/GEODE-1401
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> handle NOT_AVAILABLE in callers of getRawOldValue
> 
> 
> Diffs
> -----
> 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketRegionQueue.java 0243cde3c73190ddb51f956a3c57562d3738d9b0 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/cache/EntryEventImpl.java e241622bbfb95d2a249eae31f5ca43007476e0bb 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteDestroyMessage.java bb97d9c4f6ee63761557743aa10a65cb544d2596 
> 
> Diff: https://reviews.apache.org/r/47433/diff/
> 
> 
> Testing
> -------
> 
> precheckin
> 
> 
> Thanks,
> 
> Darrel Schneider
> 
>