You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Bryan Duxbury (JIRA)" <ji...@apache.org> on 2009/01/13 05:21:00 UTC
[jira] Created: (THRIFT-260) Some Protocol methods shouldn't have
default nil implementations
Some Protocol methods shouldn't have default nil implementations
----------------------------------------------------------------
Key: THRIFT-260
URL: https://issues.apache.org/jira/browse/THRIFT-260
Project: Thrift
Issue Type: Improvement
Components: Library (Ruby)
Reporter: Bryan Duxbury
Priority: Trivial
There are a bunch of methods defined in the Protocol base class that have default implementations that just return nil. However, many of these methods shouldn't just return nil - if they're unimplemented, it's probably an incomplete protocol. Instead, we should probably throw an NotImplementedError.
The methods that should throw the NotImplementedError are write_message_begin, write_field_begin, write_map_begin, write_list_begin, write_set_begin, write_bool, write_byte, write_i16, write_i32, write_i64, write_double, write_string.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (THRIFT-260) Some Protocol methods shouldn't have
default nil implementations
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury resolved THRIFT-260.
----------------------------------
Resolution: Fixed
Committed.
> Some Protocol methods shouldn't have default nil implementations
> ----------------------------------------------------------------
>
> Key: THRIFT-260
> URL: https://issues.apache.org/jira/browse/THRIFT-260
> Project: Thrift
> Issue Type: Improvement
> Components: Library (Ruby)
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Priority: Trivial
> Fix For: 0.1
>
> Attachments: thrift-260.patch
>
>
> There are a bunch of methods defined in the Protocol base class that have default implementations that just return nil. However, many of these methods shouldn't just return nil - if they're unimplemented, it's probably an incomplete protocol. Instead, we should probably throw an NotImplementedError.
> The methods that should throw the NotImplementedError are write_message_begin, write_field_begin, write_map_begin, write_list_begin, write_set_begin, write_bool, write_byte, write_i16, write_i32, write_i64, write_double, write_string.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-260) Some Protocol methods shouldn't have
default nil implementations
Posted by "Kevin Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12663234#action_12663234 ]
Kevin Clark commented on THRIFT-260:
------------------------------------
Yup, this makes sense and should be done.
> Some Protocol methods shouldn't have default nil implementations
> ----------------------------------------------------------------
>
> Key: THRIFT-260
> URL: https://issues.apache.org/jira/browse/THRIFT-260
> Project: Thrift
> Issue Type: Improvement
> Components: Library (Ruby)
> Reporter: Bryan Duxbury
> Priority: Trivial
>
> There are a bunch of methods defined in the Protocol base class that have default implementations that just return nil. However, many of these methods shouldn't just return nil - if they're unimplemented, it's probably an incomplete protocol. Instead, we should probably throw an NotImplementedError.
> The methods that should throw the NotImplementedError are write_message_begin, write_field_begin, write_map_begin, write_list_begin, write_set_begin, write_bool, write_byte, write_i16, write_i32, write_i64, write_double, write_string.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-260) Some Protocol methods shouldn't have
default nil implementations
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12663227#action_12663227 ]
Bryan Duxbury commented on THRIFT-260:
--------------------------------------
Add to that read_message_begin, read_field_begin, read_bool, read_byte, read_i16, read_i32, read_i64, read_double, read_string, read_list_begin, read_set_begin, read_map_begin.
> Some Protocol methods shouldn't have default nil implementations
> ----------------------------------------------------------------
>
> Key: THRIFT-260
> URL: https://issues.apache.org/jira/browse/THRIFT-260
> Project: Thrift
> Issue Type: Improvement
> Components: Library (Ruby)
> Reporter: Bryan Duxbury
> Priority: Trivial
>
> There are a bunch of methods defined in the Protocol base class that have default implementations that just return nil. However, many of these methods shouldn't just return nil - if they're unimplemented, it's probably an incomplete protocol. Instead, we should probably throw an NotImplementedError.
> The methods that should throw the NotImplementedError are write_message_begin, write_field_begin, write_map_begin, write_list_begin, write_set_begin, write_bool, write_byte, write_i16, write_i32, write_i64, write_double, write_string.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-260) Some Protocol methods shouldn't have
default nil implementations
Posted by "Kevin Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12683694#action_12683694 ]
Kevin Clark commented on THRIFT-260:
------------------------------------
Looks fine, push it.
> Some Protocol methods shouldn't have default nil implementations
> ----------------------------------------------------------------
>
> Key: THRIFT-260
> URL: https://issues.apache.org/jira/browse/THRIFT-260
> Project: Thrift
> Issue Type: Improvement
> Components: Library (Ruby)
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Priority: Trivial
> Fix For: 0.1
>
> Attachments: thrift-260.patch
>
>
> There are a bunch of methods defined in the Protocol base class that have default implementations that just return nil. However, many of these methods shouldn't just return nil - if they're unimplemented, it's probably an incomplete protocol. Instead, we should probably throw an NotImplementedError.
> The methods that should throw the NotImplementedError are write_message_begin, write_field_begin, write_map_begin, write_list_begin, write_set_begin, write_bool, write_byte, write_i16, write_i32, write_i64, write_double, write_string.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (THRIFT-260) Some Protocol methods shouldn't have
default nil implementations
Posted by "Kevin Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kevin Clark closed THRIFT-260.
------------------------------
> Some Protocol methods shouldn't have default nil implementations
> ----------------------------------------------------------------
>
> Key: THRIFT-260
> URL: https://issues.apache.org/jira/browse/THRIFT-260
> Project: Thrift
> Issue Type: Improvement
> Components: Library (Ruby)
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Priority: Trivial
> Fix For: 0.1
>
> Attachments: thrift-260.patch
>
>
> There are a bunch of methods defined in the Protocol base class that have default implementations that just return nil. However, many of these methods shouldn't just return nil - if they're unimplemented, it's probably an incomplete protocol. Instead, we should probably throw an NotImplementedError.
> The methods that should throw the NotImplementedError are write_message_begin, write_field_begin, write_map_begin, write_list_begin, write_set_begin, write_bool, write_byte, write_i16, write_i32, write_i64, write_double, write_string.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (THRIFT-260) Some Protocol methods shouldn't have
default nil implementations
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury reassigned THRIFT-260:
------------------------------------
Assignee: Bryan Duxbury
> Some Protocol methods shouldn't have default nil implementations
> ----------------------------------------------------------------
>
> Key: THRIFT-260
> URL: https://issues.apache.org/jira/browse/THRIFT-260
> Project: Thrift
> Issue Type: Improvement
> Components: Library (Ruby)
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Priority: Trivial
> Fix For: 0.1
>
> Attachments: thrift-260.patch
>
>
> There are a bunch of methods defined in the Protocol base class that have default implementations that just return nil. However, many of these methods shouldn't just return nil - if they're unimplemented, it's probably an incomplete protocol. Instead, we should probably throw an NotImplementedError.
> The methods that should throw the NotImplementedError are write_message_begin, write_field_begin, write_map_begin, write_list_begin, write_set_begin, write_bool, write_byte, write_i16, write_i32, write_i64, write_double, write_string.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-260) Some Protocol methods shouldn't have
default nil implementations
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated THRIFT-260:
---------------------------------
Attachment: thrift-260.patch
This should do it. I'll commit this tomorrow if no one objects.
> Some Protocol methods shouldn't have default nil implementations
> ----------------------------------------------------------------
>
> Key: THRIFT-260
> URL: https://issues.apache.org/jira/browse/THRIFT-260
> Project: Thrift
> Issue Type: Improvement
> Components: Library (Ruby)
> Reporter: Bryan Duxbury
> Priority: Trivial
> Fix For: 0.1
>
> Attachments: thrift-260.patch
>
>
> There are a bunch of methods defined in the Protocol base class that have default implementations that just return nil. However, many of these methods shouldn't just return nil - if they're unimplemented, it's probably an incomplete protocol. Instead, we should probably throw an NotImplementedError.
> The methods that should throw the NotImplementedError are write_message_begin, write_field_begin, write_map_begin, write_list_begin, write_set_begin, write_bool, write_byte, write_i16, write_i32, write_i64, write_double, write_string.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-260) Some Protocol methods shouldn't have
default nil implementations
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated THRIFT-260:
---------------------------------
Fix Version/s: 0.1
> Some Protocol methods shouldn't have default nil implementations
> ----------------------------------------------------------------
>
> Key: THRIFT-260
> URL: https://issues.apache.org/jira/browse/THRIFT-260
> Project: Thrift
> Issue Type: Improvement
> Components: Library (Ruby)
> Reporter: Bryan Duxbury
> Priority: Trivial
> Fix For: 0.1
>
>
> There are a bunch of methods defined in the Protocol base class that have default implementations that just return nil. However, many of these methods shouldn't just return nil - if they're unimplemented, it's probably an incomplete protocol. Instead, we should probably throw an NotImplementedError.
> The methods that should throw the NotImplementedError are write_message_begin, write_field_begin, write_map_begin, write_list_begin, write_set_begin, write_bool, write_byte, write_i16, write_i32, write_i64, write_double, write_string.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-260) Some Protocol methods shouldn't have
default nil implementations
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated THRIFT-260:
---------------------------------
Patch Info: [Patch Available]
> Some Protocol methods shouldn't have default nil implementations
> ----------------------------------------------------------------
>
> Key: THRIFT-260
> URL: https://issues.apache.org/jira/browse/THRIFT-260
> Project: Thrift
> Issue Type: Improvement
> Components: Library (Ruby)
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Priority: Trivial
> Fix For: 0.1
>
> Attachments: thrift-260.patch
>
>
> There are a bunch of methods defined in the Protocol base class that have default implementations that just return nil. However, many of these methods shouldn't just return nil - if they're unimplemented, it's probably an incomplete protocol. Instead, we should probably throw an NotImplementedError.
> The methods that should throw the NotImplementedError are write_message_begin, write_field_begin, write_map_begin, write_list_begin, write_set_begin, write_bool, write_byte, write_i16, write_i32, write_i64, write_double, write_string.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.