You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/08/29 18:41:00 UTC
[jira] [Commented] (ARTEMIS-1377) AMQP: Better handle message
disposition events
[ https://issues.apache.org/jira/browse/ARTEMIS-1377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16145878#comment-16145878 ]
ASF GitHub Bot commented on ARTEMIS-1377:
-----------------------------------------
GitHub user tabish121 opened a pull request:
https://github.com/apache/activemq-artemis/pull/1495
ARTEMIS-1377 Refactor the disposition handling code
Avoid null checking each disposition before then checking the type, also
account for not knowing the type. Rearrange the handling code to
prioritize the most common case which is "Accepted"
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tabish121/activemq-artemis ARTEMIS-1377
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1495.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1495
----
commit 5d1b7e0bea8d30d4c2be084700e667d8e8ff4888
Author: Timothy Bish <ta...@gmail.com>
Date: 2017-08-29T18:26:38Z
ARTEMIS-1377 Refactor the disposition handling code
Avoid null checking each disposition before then checking the type, also
account for not knowing the type. Rearrange the handling code to
prioritize the most common case which is "Accepted"
----
> AMQP: Better handle message disposition events
> ----------------------------------------------
>
> Key: ARTEMIS-1377
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1377
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: AMQP
> Affects Versions: 2.2.0
> Reporter: Timothy Bish
> Assignee: Timothy Bish
> Priority: Minor
> Fix For: 2.3.0
>
>
> The message disposition handler can be improved a bit around how it inspects and deals with null or unknown dispositions
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)