You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/05/25 23:02:42 UTC

[GitHub] [kafka] cmccabe commented on a diff in pull request #12183: KAFKA-13883: Implement NoOpRecord and metadata metrics

cmccabe commented on code in PR #12183:
URL: https://github.com/apache/kafka/pull/12183#discussion_r882186601


##########
core/src/main/scala/kafka/server/ControllerServer.scala:
##########
@@ -175,6 +174,11 @@ class ControllerServer(
           OptionalLong.empty()
         }
 
+        val maxIdleIntervalNs = config.metadataMaxIdleIntervalMs match {

Review Comment:
   It's more traditional to have conversion stuff like this in KafkaConfig. If you had a function like `maxIdleIntervalNs` there, it could return Option[Long] and we could convert that into OptionalLong as needed (I think a simple asScala can do it if you have the optional converter imported...)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org