You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/09/02 18:59:24 UTC
[GitHub] [arrow-datafusion] andygrove opened a new pull request, #3346: Remove panics from `common_subexpr_eliminate`
andygrove opened a new pull request, #3346:
URL: https://github.com/apache/arrow-datafusion/pull/3346
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Part of https://github.com/apache/arrow-datafusion/issues/3314
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
Optimizer can recover from rules that fail with Err but not if they panic
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
Remove panics
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
No
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove commented on pull request #3346: Remove panics from `common_subexpr_eliminate`
Posted by GitBox <gi...@apache.org>.
andygrove commented on PR #3346:
URL: https://github.com/apache/arrow-datafusion/pull/3346#issuecomment-1235814954
@avantgardnerio this is the last of these today and collectively they remove all panics from optimizer rules AFAIK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #3346: Remove panics from `common_subexpr_eliminate`
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #3346:
URL: https://github.com/apache/arrow-datafusion/pull/3346#issuecomment-1235973097
Benchmark runs are scheduled for baseline = e032bc42465f2448e1d3e6370c29022adaa64eaf and contender = f4468ea9aa7e8af285cd9d02da4131f9e5a94c9f. f4468ea9aa7e8af285cd9d02da4131f9e5a94c9f is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/93a0f6cfdf634621a7cfe260fef2a883...cea1dc0819654ce6b662479939a11ab7/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/e4aeff22fad3452fb49da193418ad4cf...5335343ef08a45cba8ecf1f3533af19a/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/63b77b013c8144229706af29b94ee621...9f69fb580c0d43e8820aee67aeacf31a/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/f90ff77049ed4f9b931abb9e798306cd...61332e3945ee47c1b7337c0549d19ed3/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] codecov-commenter commented on pull request #3346: Remove panics from `common_subexpr_eliminate`
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #3346:
URL: https://github.com/apache/arrow-datafusion/pull/3346#issuecomment-1235835683
# [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/3346?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3346](https://codecov.io/gh/apache/arrow-datafusion/pull/3346?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8d3e127) into [master](https://codecov.io/gh/apache/arrow-datafusion/commit/dadd2dc637eefee923f057b0cff1bd25b8500f47?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dadd2dc) will **decrease** coverage by `0.35%`.
> The diff coverage is `80.64%`.
```diff
@@ Coverage Diff @@
## master #3346 +/- ##
==========================================
- Coverage 85.83% 85.48% -0.36%
==========================================
Files 294 294
Lines 53752 54074 +322
==========================================
+ Hits 46137 46224 +87
- Misses 7615 7850 +235
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-datafusion/pull/3346?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...tafusion/optimizer/src/common\_subexpr\_eliminate.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/3346/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9vcHRpbWl6ZXIvc3JjL2NvbW1vbl9zdWJleHByX2VsaW1pbmF0ZS5ycw==) | `90.37% <80.64%> (-3.88%)` | :arrow_down: |
| [datafusion/expr/src/expr.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/3346/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9leHByL3NyYy9leHByLnJz) | `75.57% <0.00%> (-11.89%)` | :arrow_down: |
| [datafusion/expr/src/expr\_rewriter.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/3346/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9leHByL3NyYy9leHByX3Jld3JpdGVyLnJz) | `79.69% <0.00%> (-6.98%)` | :arrow_down: |
| [datafusion/physical-expr/src/crypto\_expressions.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/3346/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9waHlzaWNhbC1leHByL3NyYy9jcnlwdG9fZXhwcmVzc2lvbnMucnM=) | `56.11% <0.00%> (-6.39%)` | :arrow_down: |
| [datafusion/expr/src/expr\_visitor.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/3346/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9leHByL3NyYy9leHByX3Zpc2l0b3IucnM=) | `53.68% <0.00%> (-5.62%)` | :arrow_down: |
| [datafusion/sql/src/utils.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/3346/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9zcWwvc3JjL3V0aWxzLnJz) | `44.63% <0.00%> (-5.00%)` | :arrow_down: |
| [datafusion/proto/src/to\_proto.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/3346/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9wcm90by9zcmMvdG9fcHJvdG8ucnM=) | `48.89% <0.00%> (-2.19%)` | :arrow_down: |
| [datafusion/core/src/physical\_plan/planner.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/3346/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9jb3JlL3NyYy9waHlzaWNhbF9wbGFuL3BsYW5uZXIucnM=) | `77.39% <0.00%> (-2.06%)` | :arrow_down: |
| [datafusion/expr/src/expr\_schema.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/3346/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9leHByL3NyYy9leHByX3NjaGVtYS5ycw==) | `61.67% <0.00%> (-1.91%)` | :arrow_down: |
| ... and [10 more](https://codecov.io/gh/apache/arrow-datafusion/pull/3346/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove merged pull request #3346: Remove panics from `common_subexpr_eliminate`
Posted by GitBox <gi...@apache.org>.
andygrove merged PR #3346:
URL: https://github.com/apache/arrow-datafusion/pull/3346
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org