You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/01/13 01:27:02 UTC
[GitHub] [incubator-superset] craig-rueda commented on a change in pull
request #8925: Add release refinements from 0.35.2 release
craig-rueda commented on a change in pull request #8925: Add release refinements from 0.35.2 release
URL: https://github.com/apache/incubator-superset/pull/8925#discussion_r365627693
##########
File path: RELEASING/Dockerfile.from_local_tarball
##########
@@ -56,7 +56,6 @@ RUN npm ci \
WORKDIR /home/superset/apache-superset-incubating-$VERSION
RUN pip install --upgrade setuptools pip \
- && pip install -r requirements.txt \
Review comment:
Still feel the same in this case, even after the discussion. 😆 For releasing, I think it makes sense to use setup.py, whereas for building docker images that are shipped to docker hub, we should use pinned versions. I think dynamic versions in this case give a better feel for what the end user will see when running 'pip install superset'
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org