You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "korlov42 (via GitHub)" <gi...@apache.org> on 2023/01/30 16:29:22 UTC

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #1501: IGNITE-17951 Sql. Enlist partitions in transaction when preparing the execution plan.

korlov42 commented on code in PR #1501:
URL: https://github.com/apache/ignite-3/pull/1501#discussion_r1090860950


##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/rel/IndexScanNode.java:
##########
@@ -84,7 +87,7 @@ public IndexScanNode(
             RowHandler.RowFactory<RowT> rowFactory,
             IgniteIndex schemaIndex,
             InternalIgniteTable schemaTable,
-            int[] parts,
+            ColocationGroup mapping,

Review Comment:
   probably, it would be better to pass list of pairs [partition,term]



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org