You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "EpsilonPrime (via GitHub)" <gi...@apache.org> on 2023/06/30 08:22:41 UTC

[GitHub] [arrow] EpsilonPrime commented on pull request #36289: GH-35273: [C++] Add integer round kernels

EpsilonPrime commented on PR #36289:
URL: https://github.com/apache/arrow/pull/36289#issuecomment-1614307661

   Hi, I've been looking through the PR and it looks pretty good so far.  I'm going to take another pass to see if any of this makes it harder to implement round for Decimal types (I suspect not but it's worth checking).  In the meantime could you add benchmarks for the new kernels?  Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org