[GitHub] [fineract] vorburger commented on pull request #832: remove (useless) SenderTest + mockrunner-jms/nekohtml (FINERACT-938)

[GitBox <gi...@apache.org>]

vorburger commented on pull request #832:
URL: https://github.com/apache/fineract/pull/832#issuecomment-625841514


   > value of this test - was it testing anything useful 
   
   Just from looking at it, I don't see this `SenderTest` doing anything particularly useful. It doesn't `assert` on anything. I doubt this adds any real value in testing Fineract's JMS support; e.g. I don't think this test would reliably catch any possible regressions in Fineract's JMS support. (Which isn't exactly it's top most used feature anyway, as far as I know.)
   
   > and whether we had plans to build more tests like it?
   
   according to [git log history](https://github.com/apache/fineract/commits/develop/fineract-provider/src/test/java/org/apache/fineract/notification/SenderTest.java), it was written 3 years ago, by @adhyans ... Adhyan, if you are still alive and have any interest in Fineract, would be interested to chime in here and let us know if you can still sleep well at night :smile: if we delete this `SenderTest`? It's dependency on `mockrunner-jms` was giving us a hard time (see FINERACT-846 and FINERACT-938), and we don't' see much value in that particular test anymore, compared to the dependency management headache its use of `mockrunner-jms` (which is, at least now, only used in that test), and we'd like to remove it. Do you have any strong objections?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org