You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/01/10 01:45:46 UTC

[GitHub] [tvm] Icemist commented on pull request #9186: [ONNX] Add MatMulInteger16 contrib op

Icemist commented on pull request #9186:
URL: https://github.com/apache/tvm/pull/9186#issuecomment-1008482107


   @abhikran-quic 
   Could I please ask why did you delete the code branch under the ONNX_DEFAULT_CONFIGS["use_nt_batch_matmul"] parameter?
   I found that after this change, some of the code samples stopped working with an error like _“Check failed: (reporter->AssertEQ(xk, yk)) is false: BatchDot: shapes of x and y is inconsistent,  x shape=[16, 384, 384], y shape=[16, 384, 64]“_
   So now I see ONNX_DEFAULT_CONFIGS is not used by anyone. But The same logic with use_nt_batch_matmul is there for tensorflow.
   Can we restore this logic? Will it affect the MatMulInteger16 operation you added?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org