You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/08/18 15:02:44 UTC
[GitHub] [nifi-minifi-cpp] lordgamez opened a new pull request, #1396: Fix ConsumeKafka SSL tests with newer OpenSSL versions
lordgamez opened a new pull request, #1396:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1396
Regenerate certificates to use SHA256 cipher instead of MD5 to avoid "ca md too weak" error when linked to OpenSSL 3.
Fixes the following tests when using newer OpenSSL versions:
features/kafka.feature: ConsumeKafka receives data via SSL
features/kafka.feature: ConsumeKafka receives data via SASL SSL
https://issues.apache.org/jira/browse/MINIFICPP-1913
--------------------------------------------
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically main)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1396: Fix ConsumeKafka SSL tests with newer OpenSSL versions
Posted by GitBox <gi...@apache.org>.
lordgamez commented on code in PR #1396:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1396#discussion_r949272897
##########
docker/test/integration/resources/kafka_broker/conf/certs/server_cert.key:
##########
@@ -0,0 +1,28 @@
+-----BEGIN PRIVATE KEY-----
Review Comment:
It's added to the server keystore, we use it through the keystore in the tests, I want to keep it in the repository in case we need it in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1396: Fix ConsumeKafka SSL tests with newer OpenSSL versions
Posted by GitBox <gi...@apache.org>.
lordgamez commented on code in PR #1396:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1396#discussion_r949272897
##########
docker/test/integration/resources/kafka_broker/conf/certs/server_cert.key:
##########
@@ -0,0 +1,28 @@
+-----BEGIN PRIVATE KEY-----
Review Comment:
It's added to the server keystore, I want to keep it in the repository in case we need it in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm closed pull request #1396: MINIFICPP-1913 Fix ConsumeKafka SSL tests with newer OpenSSL versions
Posted by GitBox <gi...@apache.org>.
szaszm closed pull request #1396: MINIFICPP-1913 Fix ConsumeKafka SSL tests with newer OpenSSL versions
URL: https://github.com/apache/nifi-minifi-cpp/pull/1396
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] adam-markovics commented on a diff in pull request #1396: Fix ConsumeKafka SSL tests with newer OpenSSL versions
Posted by GitBox <gi...@apache.org>.
adam-markovics commented on code in PR #1396:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1396#discussion_r949268106
##########
docker/test/integration/resources/kafka_broker/conf/certs/server_cert.key:
##########
@@ -0,0 +1,28 @@
+-----BEGIN PRIVATE KEY-----
Review Comment:
Where is this file used? I don't see any reference to it. Also applies to its `.pem` brother.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org