You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/08/19 13:52:20 UTC
[jira] [Commented] (BEAM-409) Incorrect use of Math.ceil in
ApproximateQuantiles
[ https://issues.apache.org/jira/browse/BEAM-409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15428217#comment-15428217 ]
ASF GitHub Bot commented on BEAM-409:
-------------------------------------
GitHub user JasonMWhite opened a pull request:
https://github.com/apache/incubator-beam/pull/853
[BEAM-409] Ensure precision in division of Longs in ApproximateQuantilesCombineFn
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [x] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [x] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [x] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
---
This PR resolves [BEAM-409](https://issues.apache.org/jira/browse/BEAM-409) by casting a long to a float before division.
@swegner Would you mind reviewing for me?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/JasonMWhite/incubator-beam fix_beam_409
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/853.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #853
----
commit 8a2bc49c1a7ae2467fc2cbbdaad6d10c1411dd16
Author: Jason White <ja...@shopify.com>
Date: 2016-08-19T13:46:52Z
cast long to float before division to ensure precision
----
> Incorrect use of Math.ceil in ApproximateQuantiles
> --------------------------------------------------
>
> Key: BEAM-409
> URL: https://issues.apache.org/jira/browse/BEAM-409
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Scott Wegner
> Priority: Minor
> Labels: findbugs, newbie, starter
>
> [FindBugs ICAST_INT_CAST_TO_DOUBLE_PASSED_TO_CEIL|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml#L274]: Integral value cast to double and then passed to Math.ceil
> Applies to: [ApproximateQuanitles|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/ApproximateQuantiles.java#L349].
> This is a good starter bug. When fixing, please remove the corresponding entries from [findbugs-filter.xml|https://github.com/apache/incubator-beam/blob/master/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml] and verify the build passes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)